bitwarden / clients

Bitwarden client apps (web, browser extension, desktop, and cli).
https://bitwarden.com
Other
9.21k stars 1.24k forks source link

No prompt (add login notification) offered to save the credentials for some sites #320

Closed Moxville closed 3 years ago

Moxville commented 7 years ago

Hi Kyle,

Today I tried adding credentials for some new sites via. extension. For some sites I got the prompt and for some sites I did not get the prompt a) The prompt I get to save the credentials is not constant "Should bitwarden remember this password for you?". During site login time the prompt appears and disappears few times (not constant). Eventually I could click the button to save the credentials. But i think the "prompt" should be constant until the user decides

b) For below mentioned sites I logged-in i did not see this prompt "Should bitwarden remember this password for you?" . I tried few times again but no prompt to save the credentials https://www.isaca.org https://forum.glasswire.com/ https://ebiz.licindia.in http://www.m-hddl.com/ https://mega.nz/ https://www.overclock.net/login https://freescan.qualys.com/freescan-front/ https://www.scribd.com/ https://www.snapdeal.com/ https://home.sophos.com/ http://www.timesjobs.com http://www.vn-zoom.com/ https://www.sevenforums.com/ http://forum.pdf.wondershare.com/

Browser I use Vivaldi 1.12.955.38 (Stable channel) (32-bit) Bitwarden extension v1.19.1 (installed)

kspearrin commented 7 years ago

a) This is because the website is likely loading a new page. We cannot show the prompt until the page has been loaded again.

b) These are all caused by websites that are creating login forms in some exceptional way. I have gone through them all and have added fixes for the following cases.

http://www.m-hddl.com/ https://home.sophos.com/ https://www.sevenforums.com/ https://freescan.qualys.com/freescan-front/ https://www.scribd.com/ http://www.timesjobs.com http://www.vn-zoom.com/ http://forum.pdf.wondershare.com/

As for the others, I have no fix at this time. Thanks for all the examples though.

Moxville commented 7 years ago

Thank You for the fixes. If I come across such similar sites (if any) will post it

snhv commented 6 years ago

I concur this issue, even with google.com! With Chorme, no prompt at all with google.com or github.com With Firefox, prompt appears but credentials are not saved in vault. I'm new to bitwarden so I haven't tried many sites.

kspearrin commented 6 years ago

@snhv I just tested github.com and it works just fine.. Is your vault unlocked?

snhv commented 6 years ago

Hi Kyle, that's fast!

Ok i tested again with vault unlocked. It works in both Chrome and Firefox. Tho I remember when I did that like 8 hrs ago, vault unlocked, it didn't work, but nevermind. Thanks.

However, shouldn't bitwarden recognize and conveniently prompt us for unlocking?

Some other suggestions (sorry for duplicate if any):

Thank you.

ax-meyer commented 6 years ago

I just experienced the same behaviour on community.bitwarden.com. I created a new account and did not get a prompt to save the credentials.

moham96 commented 6 years ago

same problem on https://discourse.coreelec.org/ I think the problem is in any site that uses discourse like https://community.bitwarden.com @kspearrin any updates on these sites ?

garaboncias commented 5 years ago

same for https://protonvpn.com

Cereal-Killa commented 5 years ago

Same here on many different websites. I'm a long time robotform user and their extension does an amazing job on this criteria.

kspearrin commented 5 years ago

@moham96 The discourse cases should now be fixed.

jswinner commented 5 years ago

No add login prompt for community.bitwarden.com using FF 65 Ubuntu snap edition. BW 1.38 extension version Been a few others along the way, but did not work on Tailscale.com Vivaldi 3.5.2115.87 Ubuntu 20.04

Mazino-Urek commented 5 years ago

not working on https://bdjobs.com

jdgregson commented 5 years ago

I haven't actually seen the "Add Login" prompt at all, on any website, which is very disconcerting. This worked flawlessly with LastPass.

UPDATE I just deleted a site and logged in again and got the prompt. So it works sometimes, at least.

xeor commented 5 years ago

Same here.. Currently evaluating bitwarden, but still havent seen the "save password" prompt (after 5+ different pages)

jdgregson commented 5 years ago

@xeor It's possible that you're just not noticing it. Unlike the LastPass prompt, which is a box that slides in from the right, the Bitwarden prompt is a top bar like Chrome messages which spans the top of the site. I found that it is already there when the page loads, with no movement or visual indication that something needs your attention, so it's really easy to miss, or mistake for part of the site. I'd prefer if the Bitwarden team revisits that prompt and makes it more distinct and attention grabbing.

BlueGreenMagick commented 5 years ago

not working for streamable.com, and many other sites as well.

ghost commented 5 years ago

I think there is a problem, Bitwarden no longer offers me to save my logins and passwords.

EDIT : Firefox 68 - 64Bits

kspearrin commented 5 years ago

It would be helpful if you shared which browser you all are using.

ghost commented 5 years ago

Same problem with Firefox 69 Beta. Windows 10 - 64 Bits

EDIT : I had no problem a few days ago

EDIT 2 : Bitwarden works fine on Chrome, but not Firefox

BlueGreenMagick commented 5 years ago

I am using Firefox ver69.0b4 64-bit on windows 10

kspearrin commented 5 years ago

Looks like there was a bug in latest Firefox release. Should be fixed in v1.40.1

markandersonus commented 5 years ago

I have the same issue on Chrome on Win 10. I don't recall EVER being asked to add a new site. (I get prompts to update password). Trying to push it for our Enterprise, but hard work when CFO has to enter every single login to the vault manually

Trying to get him off RoboForms, which ALWAYS asks to add a new site, as did my LastPass

silasdavis commented 5 years ago

Coming to this a Bitwarden user and developer of a login form. My login form is generate a prompt to save password but my sign up form is not. As far as I can tell all of my fields are semantically marked up with, for example autocomplete=new-password. It's obviously a far superior experience if bitwarden will remember (ideally generate) password on first entry.

What heuristics do you use for this?

The site is a single-page-app so there is no true reload and the forms have no action or method attributes. I wonder if that is a problem?

funnell commented 5 years ago

At some point I stopped being able to automatically add passwords, although I can't remember when this happened. Sometimes I see the Bitwarden bar at the top of the page but I only see the logo on the left and an x on the right. I'm using Safari 12.1.2.

ghost commented 4 years ago

Same problem here with Chrome 79 on Windows. Sometime it works, sometime not

bauerp commented 4 years ago

Often doesn't prompt using Macos Safari 13.0.5.

Example: https://www.bebe.com

palytoxin commented 4 years ago

It seems like a common problem. same problem in https://crowdin.com/

onderbagci commented 4 years ago

I have this issue on Twitter web and some other sites I didn't care at the time. Windows 10 / Chrome 83.0.4103.116

aelsharawi commented 4 years ago

me too

aelsharawi commented 4 years ago

no solution after 3 years?

cscharf commented 4 years ago

no solution after 3 years?

This, unfortunately has been an evolving problem (fixed quite a few times) and will always exist to a degree. Anyone who can jump in to offer help (added the help wanted label) is more than welcome to take a look at the auto-fill matching and logic. A fair degree of the sites experiencing issues will be 1-off fixes that are necessary although some of the general auto-fill issues described in this thread are likely interlinked with a similar or same root cause.

This is on our radar to start looking at but we do welcome anyone willing to jump in ahead of time.

Thanks for your patience and support of Bitwarden!

PrinceMerluza commented 4 years ago

I'm glad I'm not the only one having this issue. I'm new to using Bitwarden and I forgot to save the generated password as I was expecting it to prompt me to save the newly registered credentials (it didn't) and I copied something else to the clipboard already. Anyway, I guess it'll just be manual saving for such sites.

jdgregson commented 4 years ago

I've already developed the habit of creating the entry in BitWarden before signing up for an account after going through that too many times.

KaiDevrim commented 3 years ago

I have never gotten a prompt in any website and I am using Edge (Chromium) Dev latest.

stonelazy commented 3 years ago

I just recently migrated from LastPass, i have never had this problem. But in Bitwarden it is a consistent issue of not offering to save password in so many websites. One website that i recently faced issue with is https://leetcode.com

Talk2Giuseppe commented 3 years ago

Adding to the list that the issue is random and intermittent. Kinda annoying on the reliability side. Would be a nice piece of software if reliable and stable. At the moment, I can't suggest it to anybody. Seems weird that browsers can consistently offer to save PWs, but not BitWarden.

dave-castle commented 3 years ago

Migrated from 1password due to selfhosting feature, but got also no prompt for pw saving, whether in Firefox or safari on macOS, so I am thinking to move back 😔

jdgregson commented 3 years ago

It's also important to note that when I do see the "Save Password" prompt, it flashes every second as if it is being removed from the DOM and re-added. I have seen this on several browsers and affecting several users on different computers.

Tursko commented 3 years ago

I've faced this issue since moving to Bitwarden. It's one of the only things stopping me from switching family members over to the service. I encounter it somewhat randomly on even common sites. Last night my brand new Gmail login did not prompt to 'save on Bitwarden', so I just created a manual entry.

ztlevi commented 3 years ago

same on www.ticktick.com

soberhofer commented 3 years ago

I have setup BitWarden and am Using it on macOS. I've installed the Desktop Application and the Safari Extension, via the App Store. I've tried logging in to existing accounts as well as creating new ones in Safari on various Sites. Bitwarden never prompted me to save the credentials. Using Safari 14 on macOS Big Sur. seeing as the issue is over 3 years old it doesn't look like it's going to get fixed, or looked at, is it?

denzilc commented 3 years ago

What makes this behavior possible on LastPass but not on Bitwarden?

In addition, assuming this doesn't work - what's the recommended workaround or solution?

cscharf commented 3 years ago

We are currently looking at a more holistic approach to these issues and have someone actively looking into it now.

eliykat commented 3 years ago

@denzilc It's a tricky problem to solve, as there are many ways of designing login and password change forms, and our script has to try to capture as many as possible.

As a workaround, you can create the login in the Bitwarden browser extension first, and then autofill it into the website's registration or login form.

5abred commented 3 years ago

I've seen this issue on some websites like raidforums, mangadex, ..etc, but never on other websites and I've read that its fix is pending so I'm trying to set the login before but it's really annoying, hoping for a solution but seeing that this is a 3 years old issue I'm skeptical. also, I just started using bitwarden is there anything to help?

xeor commented 3 years ago

Anyone with insights on what's needed to get sites supported as default? Maybe we, the people in this issue can also contact a bunch of those sites that are not working. But then we need something to tell them, what to change so they will work

5abred commented 3 years ago

Anyone with insights on what's needed to get sites supported as default? Maybe we, the people in this issue can also contact a bunch of those sites that are not working. But then we need something to tell them, what to change so they will work

I don't it's something wrong with the website itself rather with the logic of the software for example Lastpass works well with Raidforums but bitwarden won't.

xeor commented 3 years ago

Anyone with insights on what's needed to get sites supported as default? Maybe we, the people in this issue can also contact a bunch of those sites that are not working. But then we need something to tell them, what to change so they will work

I don't it's something wrong with the website itself rather with the logic of the software for example Lastpass works well with Raidforums but bitwarden won't.

That might also be because lastpass is a much bigger company and can use a lot more resources on one-off fixes for specific pages. In bitwardens case, those resources might very well be the community

bd-g commented 3 years ago

I haven't actually seen the "Add Login" prompt at all, on any website. I have tried a variety of common websites too, with vault unlocked.

eliykat commented 3 years ago

@xeor I appreciate the offer, but for now I think it's on us to improve the detection algorithm for the save prompt. The help wanted tag still applies if anyone has the skills & time to dive into the code (but we're working on it at our end either way).