Closed Tyrrrz closed 9 months ago
Attention: 32 lines
in your changes are missing coverage. Please review.
Comparison is base (
b39384d
) 63.76% compared to head (a2807c2
) 63.75%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@jrmccannon curious about your opinion since you added some of these models
A lot of the default values were mainly so that if the classes were newed up, we could avoid some null reference exceptions. Since we're now enforcing the records to be created, you would have to explicitly assign null to the newed up record.
@abergs @jrmccannon do you think this is approvable or would you rather I revert something?
Found a way to assign inline docs to properties -- using the
<para>
on the type definition.Migrated some of our older models to use
{ get; init; }
and/orrecord
where possible. This is a breaking change to models related to event logging, but those have not been released yet.