bitwarden / passwordless-dotnet

Bitwarden Passwordless.dev .NET SDK.
https://bitwarden.com/
Apache License 2.0
36 stars 11 forks source link

.NET SDK: Options pattern is not reading updated values #124

Closed jonashendrickx closed 7 months ago

jonashendrickx commented 7 months ago

We currently cannot read updated values when the appsettings.json or environment variables change. The ASP.NET Identity SDK has to be fixed separately.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 60.19%. Comparing base (6a01e85) to head (12931c9).

Files Patch % Lines
src/Passwordless/ServiceCollectionExtensions.cs 50.00% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #124 +/- ## ========================================== + Coverage 60.00% 60.19% +0.19% ========================================== Files 42 42 Lines 615 613 -2 Branches 54 52 -2 ========================================== Hits 369 369 + Misses 240 238 -2 Partials 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jonashendrickx commented 7 months ago

123