Closed Tyrrrz closed 3 months ago
Attention: Patch coverage is 86.27451%
with 7 lines
in your changes missing coverage. Please review.
Project coverage is 61.39%. Comparing base (
a1bc696
) to head (7b6a392
).
Files | Patch % | Lines |
---|---|---|
src/Passwordless/PasswordlessClient.cs | 87.50% | 5 Missing and 1 partial :warning: |
src/Passwordless/ServiceCollectionExtensions.cs | 50.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR does the following:
ApiSecret
from service registration (eager) to when the API requests are actually sent (lazy).ApiSecret
and have it fail only when the client is actually used.ApiUrl
(defaulting toCloudApiUrl
when not set) from service registration to client initialization.PasswordlessClient
can be initialized with anull
value ofApiUrl
, even without DI, resulting in a more uniform behavior.ApiUrl ??= CloudApiUrl
even though the former can never benull
in our type model.Both of these changes also significantly simplify the service registration code, while making all initialization routes (DI or non-DI) work the same way.