bitwarden / sdk

Bitwarden Secrets Manager SDK
Other
265 stars 49 forks source link

fix: wasm2js breaking wasm builds #1149

Closed coroiu closed 1 month ago

coroiu commented 1 month ago

🎟️ Tracking

📔 Objective

⏰ Reminders before review

🦮 Reviewer guidelines

github-actions[bot] commented 1 month ago

Logo Checkmarx One – Scan Summary & Details8b692432-425e-49ab-aaa3-18bd724d98f8

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 61 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /publish-python.yml: 108 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 54 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 54 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /publish-bws.yml: 163 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /release-bws.yml: 44 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /publish-napi.yml: 111 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-swift.yml: 96 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 173 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 86 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /publish-rust-crates.yml: 77 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 131 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /publish-wasm.yml: 87 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /publish-bws.yml: 169 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 338 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /publish-bws.yml: 93 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /release-bws.yml: 52 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /publish-wasm.yml: 87 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /publish-bws.yml: 163 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-cli.yml: 86 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-cli.yml: 173 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 54 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 131 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 54 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-swift.yml: 96 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /publish-bws.yml: 169 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /publish-rust-crates.yml: 77 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /publish-python.yml: 108 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 61 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /release-bws.yml: 44 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-cli.yml: 338 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /release-bws.yml: 52 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /publish-bws.yml: 93 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /publish-napi.yml: 111 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /publish-rust-crates.yml: 76
MEDIUM Unpinned Actions Full Length Commit SHA /release-bws.yml: 43
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 85
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 337
MEDIUM Unpinned Actions Full Length Commit SHA /publish-python.yml: 107
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 60
MEDIUM Unpinned Actions Full Length Commit SHA /publish-wasm.yml: 86
MEDIUM Unpinned Actions Full Length Commit SHA /publish-bws.yml: 162
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 53
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 53
MEDIUM Unpinned Actions Full Length Commit SHA /publish-bws.yml: 92
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 172
MEDIUM Unpinned Actions Full Length Commit SHA /publish-bws.yml: 168
MEDIUM Unpinned Actions Full Length Commit SHA /build-swift.yml: 95
MEDIUM Unpinned Actions Full Length Commit SHA /release-bws.yml: 51
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 130
MEDIUM Unpinned Actions Full Length Commit SHA /publish-napi.yml: 110
LOW Unpinned Actions Full Length Commit SHA /publish-rust-crates.yml: 76
LOW Unpinned Actions Full Length Commit SHA /build-cli.yml: 85
LOW Unpinned Actions Full Length Commit SHA /publish-napi.yml: 110
LOW Unpinned Actions Full Length Commit SHA /build-cli.yml: 172
LOW Unpinned Actions Full Length Commit SHA /publish-bws.yml: 92
LOW Unpinned Actions Full Length Commit SHA /publish-bws.yml: 162
LOW Unpinned Actions Full Length Commit SHA /release-bws.yml: 43
LOW Unpinned Actions Full Length Commit SHA /publish-bws.yml: 168
LOW Unpinned Actions Full Length Commit SHA /release-bws.yml: 51
LOW Unpinned Actions Full Length Commit SHA /build-cli.yml: 337
LOW Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 130
LOW Unpinned Actions Full Length Commit SHA /build-swift.yml: 95
LOW Unpinned Actions Full Length Commit SHA /publish-wasm.yml: 86
LOW Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 60
LOW Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 53
LOW Unpinned Actions Full Length Commit SHA /publish-python.yml: 107
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.15%. Comparing base (6460db2) to head (f7fdeb5). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1149 +/- ## ========================================== - Coverage 58.17% 58.15% -0.03% ========================================== Files 197 197 Lines 13587 13587 ========================================== - Hits 7904 7901 -3 - Misses 5683 5686 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.