bitwarden / sdk

Bitwarden Secrets Manager SDK
Other
265 stars 49 forks source link

[PM-13377] Remove moved libraries #1151

Closed Hinton closed 1 month ago

Hinton commented 1 month ago

🎟ī¸ Tracking

https://bitwarden.atlassian.net/browse/PM-13377

📔 Objective

PR for removing duplicates crates caused by the split from unified SDK to SM specific SDK.

⏰ Reminders before review

đŸĻŽ Reviewer guidelines

github-actions[bot] commented 1 month ago

Logo Checkmarx One – Scan Summary & Details – 58c0fc02-0eea-4570-9a1c-e6b5c247e881

Fixed Issues

Severity Issue Source File / Package
MEDIUM Parameter_Tampering /languages/kotlin/app/src/main/java/com/bitwarden/myapplication/MainActivity.kt: 384
MEDIUM Unpinned Actions Full Length Commit SHA /build-swift.yml: 95
MEDIUM Unpinned Actions Full Length Commit SHA /release-swift.yml: 73
MEDIUM Unpinned Actions Full Length Commit SHA /release-swift.yml: 136
MEDIUM Unpinned Actions Full Length Commit SHA /publish-internal.yml: 61
MEDIUM Unpinned Actions Full Length Commit SHA /publish-internal.yml: 67
LOW Healthcheck Instruction Missing /Dockerfile: 38
LOW Unpinned Actions Full Length Commit SHA /publish-internal.yml: 67
LOW Unpinned Actions Full Length Commit SHA /release-swift.yml: 73
LOW Unpinned Actions Full Length Commit SHA /build-swift.yml: 95
LOW Unpinned Actions Full Length Commit SHA /release-swift.yml: 136
LOW Unpinned Actions Full Length Commit SHA /publish-internal.yml: 61
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 10.17%. Comparing base (38ecf13) to head (406c2c8). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1151 +/- ## =========================================== - Coverage 58.60% 10.17% -48.44% =========================================== Files 198 19 -179 Lines 13782 1101 -12681 =========================================== - Hits 8077 112 -7965 + Misses 5705 989 -4716 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.