Closed Hinton closed 3 weeks ago
Checkmarx One ā Scan Summary & Details ā 3dec9e12-b070-4f97-b17c-d3913a549eff
Severity | Issue | Source File / Package | Checkmarx Insight |
---|---|---|---|
![]() |
Unpinned Actions Full Length Commit SHA | /publish-rust-crates.yml: [167](https://github.com/bitwarden/sdk/blob/ps/bitwarden-core//.github/workflows/publish-rust-crates.yml# L167) | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
Severity | Issue | Source File / Package |
---|---|---|
![]() |
Unpinned Actions Full Length Commit SHA | /publish-rust-crates.yml: [156](https://github.com/bitwarden/sdk/blob/ps/bitwarden-core//.github/workflows/publish-rust-crates.yml# L156) |
Attention: Patch coverage is 0%
with 17 lines
in your changes missing coverage. Please review.
Project coverage is 59.34%. Comparing base (
85ac7c4
) to head (b46ac06
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
šļø Tracking
https://bitwarden.atlassian.net/browse/PM-8301
š Objective
Extract the
require
macro and common uniffi logic to a new crate calledbitwarden-core
since it's required for extracting other bitwarden functionality.ā° Reminders before review
š¦® Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ā¹ļø (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or š (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or ā ļø (:warning:
) for more significant problems or concerns needing attention:seedling:
) or ā»ļø (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes