bitwarden / sdk

Bitwarden SDK.
Other
205 stars 37 forks source link

[PM-8301] Create bitwarden-core with macro and uniffi #824

Closed Hinton closed 3 weeks ago

Hinton commented 3 weeks ago

šŸŽŸļø Tracking

https://bitwarden.atlassian.net/browse/PM-8301

šŸ“” Objective

Extract the require macro and common uniffi logic to a new crate called bitwarden-core since it's required for extracting other bitwarden functionality.

ā° Reminders before review

šŸ¦® Reviewer guidelines

github-actions[bot] commented 3 weeks ago

Logo Checkmarx One ā€“ Scan Summary & Details ā€“ 3dec9e12-b070-4f97-b17c-d3913a549eff

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /publish-rust-crates.yml: [167](https://github.com/bitwarden/sdk/blob/ps/bitwarden-core//.github/workflows/publish-rust-crates.yml# L167) Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /publish-rust-crates.yml: [156](https://github.com/bitwarden/sdk/blob/ps/bitwarden-core//.github/workflows/publish-rust-crates.yml# L156)
codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 59.34%. Comparing base (85ac7c4) to head (b46ac06).

Files Patch % Lines
crates/bitwarden-core/src/uniffi_support.rs 0.00% 12 Missing :warning:
crates/bitwarden/src/auth/login/password.rs 0.00% 2 Missing :warning:
crates/bitwarden-core/src/error.rs 0.00% 1 Missing :warning:
crates/bitwarden-core/src/lib.rs 0.00% 1 Missing :warning:
crates/bitwarden/src/vault/cipher/linked_id.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #824 +/- ## ========================================== - Coverage 59.36% 59.34% -0.02% ========================================== Files 181 183 +2 Lines 12420 12423 +3 ========================================== Hits 7373 7373 - Misses 5047 5050 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.