bitwarden / sdk

Bitwarden SDK.
Other
237 stars 37 forks source link

[PM-8301] Create bitwarden-vault #825

Closed Hinton closed 3 months ago

Hinton commented 3 months ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-8301

📔 Objective

Continue extracting functionality from bitwarden to new crates.

⏰ Reminders before review

🦮 Reviewer guidelines

github-actions[bot] commented 3 months ago

Logo Checkmarx One – Scan Summary & Detailsec3f8fca-4156-425f-ac62-fdfe533c721f

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /publish-rust-crates.yml: [178](https://github.com/bitwarden/sdk/blob/ps/bitwarden-vault//.github/workflows/publish-rust-crates.yml# L178) Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /publish-rust-crates.yml: [167](https://github.com/bitwarden/sdk/blob/ps/bitwarden-vault//.github/workflows/publish-rust-crates.yml# L167)
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 42.50765% with 188 lines in your changes missing coverage. Please review.

Project coverage is 59.25%. Comparing base (5ee45a1) to head (b4b8658).

Files Patch % Lines
crates/bitwarden/src/platform/fido2/mod.rs 0.00% 73 Missing :warning:
crates/bitwarden-vault/src/exporters.rs 66.09% 59 Missing :warning:
crates/bitwarden-vault/src/cipher/cipher.rs 36.84% 12 Missing :warning:
crates/bitwarden-vault/src/cipher/login.rs 0.00% 5 Missing :warning:
crates/bitwarden/src/mobile/tool/client_sends.rs 0.00% 5 Missing :warning:
...ates/bitwarden/src/platform/fido2/authenticator.rs 0.00% 5 Missing :warning:
crates/bitwarden-vault/src/cipher/attachment.rs 0.00% 3 Missing :warning:
crates/bitwarden-vault/src/domain.rs 0.00% 3 Missing :warning:
crates/bitwarden/src/vault/sync.rs 0.00% 2 Missing :warning:
crates/bitwarden-core/src/error.rs 0.00% 1 Missing :warning:
... and 20 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #825 +/- ## ========================================== - Coverage 59.34% 59.25% -0.10% ========================================== Files 183 186 +3 Lines 12423 12416 -7 ========================================== - Hits 7373 7357 -16 - Misses 5050 5059 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.