Closed Hinton closed 3 months ago
Checkmarx One – Scan Summary & Details – ec3f8fca-4156-425f-ac62-fdfe533c721f
Severity | Issue | Source File / Package | Checkmarx Insight |
---|---|---|---|
Unpinned Actions Full Length Commit SHA | /publish-rust-crates.yml: [178](https://github.com/bitwarden/sdk/blob/ps/bitwarden-vault//.github/workflows/publish-rust-crates.yml# L178) | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
Severity | Issue | Source File / Package |
---|---|---|
Unpinned Actions Full Length Commit SHA | /publish-rust-crates.yml: [167](https://github.com/bitwarden/sdk/blob/ps/bitwarden-vault//.github/workflows/publish-rust-crates.yml# L167) |
Attention: Patch coverage is 42.50765%
with 188 lines
in your changes missing coverage. Please review.
Project coverage is 59.25%. Comparing base (
5ee45a1
) to head (b4b8658
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-8301
📔 Objective
Continue extracting functionality from
bitwarden
to new crates.VaultLocked
tobitwarden-core
.bitwarden/src/vault
models tobitwarden-vault
crate.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or ⚠️ (:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes