bitwarden / sdk

Bitwarden SDK.
Other
205 stars 37 forks source link

[PM-8301] Create bitwarden-send #829

Closed Hinton closed 3 weeks ago

Hinton commented 3 weeks ago

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-8301

📔 Objective

Extract send to separate crate.

⏰ Reminders before review

🦮 Reviewer guidelines

github-actions[bot] commented 3 weeks ago

Logo Checkmarx One – Scan Summary & Details7d6d845b-18b3-46fa-b104-905dfd670fd5

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /publish-rust-crates.yml: [189](https://github.com/bitwarden/sdk/blob/ps/bitwarden-send//.github/workflows/publish-rust-crates.yml# L189) Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /publish-rust-crates.yml: [178](https://github.com/bitwarden/sdk/blob/ps/bitwarden-send//.github/workflows/publish-rust-crates.yml# L178)
codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 59.22%. Comparing base (e5a8dba) to head (9316f60).

Files Patch % Lines
crates/bitwarden-send/src/send.rs 78.57% 3 Missing :warning:
crates/bitwarden-send/src/error.rs 0.00% 1 Missing :warning:
crates/bitwarden-send/src/lib.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #829 +/- ## ======================================= Coverage 59.22% 59.22% ======================================= Files 186 188 +2 Lines 12396 12403 +7 ======================================= + Hits 7341 7346 +5 - Misses 5055 5057 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.