bitwarden / sdk

Bitwarden SDK.
Other
237 stars 37 forks source link

Flip the dependency between exporters and vault #833

Closed Hinton closed 3 months ago

Hinton commented 3 months ago

📔 Objective

In preparation for #798 we need to flip the relationship between vault and exporters. Due to exporters in the future getting a client_exporters which means they need to be able to access the vault models to properly model it.

⏰ Reminders before review

đŸĻŽ Reviewer guidelines

github-actions[bot] commented 3 months ago

Logo Checkmarx One – Scan Summary & Details – 15e5a497-ed64-41a0-bc48-353c05bf787b

No New Or Fixed Issues Found

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 28.57143% with 10 lines in your changes missing coverage. Please review.

Project coverage is 59.24%. Comparing base (dfd0ba8) to head (8f6ebf6).

Files Patch % Lines
crates/bitwarden-exporters/src/models.rs 28.57% 10 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #833 +/- ## ======================================= Coverage 59.23% 59.24% ======================================= Files 186 186 Lines 12428 12426 -2 ======================================= Hits 7362 7362 + Misses 5066 5064 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.