Closed Hinton closed 3 months ago
Checkmarx One â Scan Summary & Details â 15e5a497-ed64-41a0-bc48-353c05bf787b
Attention: Patch coverage is 28.57143%
with 10 lines
in your changes missing coverage. Please review.
Project coverage is 59.24%. Comparing base (
dfd0ba8
) to head (8f6ebf6
).
Files | Patch % | Lines |
---|---|---|
crates/bitwarden-exporters/src/models.rs | 28.57% | 10 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
đ Objective
In preparation for #798 we need to flip the relationship between vault and exporters. Due to exporters in the future getting a
client_exporters
which means they need to be able to access the vault models to properly model it.â° Reminders before review
đĻŽ Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or âšī¸ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or đ (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or â ī¸ (:warning:
) for more significant problems or concerns needing attention:seedling:
) or âģī¸ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes