Closed Hinton closed 3 months ago
Checkmarx One â Scan Summary & Details â eb7837b5-bbbd-4980-b007-7bc0b88bed73
Attention: Patch coverage is 5.76923%
with 147 lines
in your changes missing coverage. Please review.
Project coverage is 58.83%. Comparing base (
3f56e58
) to head (2b9ceb1
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
đī¸ Tracking
đ Objective
This PR establishes explicit error types for the fido logic.
In order to extract the fido logic into a separate
bitwarden-fido
crate, we need to remove the dependencies on thebitwarden
logic. Most of this is either theClient
struct which is currently difficult, or theError
andResult
types which this PR focuses on.â° Reminders before review
đĻŽ Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or âšī¸ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or đ (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or â ī¸ (:warning:
) for more significant problems or concerns needing attention:seedling:
) or âģī¸ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes