Make client internally mutable

[dani-garcia]

📔 Objective

We're having some deadlock problems with the Passkey API by calling certain SDK functions on the passkey-rs callbacks. These issues are caused because we're holding a reference to the RwLock during the execution of the Passkey operation and so calling into the SDK from inside that will deadlock.

To solve it we can't just use a lock at the client level, and so we need to move to using interior mutability, I've revived an old PR (#70) where we started doing that.

This PR is split into two commits, for ease of review:

• Remove all the muts and locks for uniffi: This removes the use of RwLock in bitwarden-uniffi and the &mut references used in the bitwarden Client API. Note that this alone won't compile.
• Make client internally mutable: Implements RwLocks in Client to make it internally mutable.

Some notes of what the change entails:

• I had to wrap EncryptionSettings in a RwLock<Arc<>> to get the API working, this is quite unfortunate as it forces us to clone EncryptionSettings to modify it when calling set_org_keys. We can't wrap the org_keys in a RwLock as we will get lifetime issues in get_key. I think the best solution for this will be the work on creating a Crypto store that only returns opaque key references, so we might want to prioritize that.
• I extracted external_client from ApiConfigurations, as it's never mutated and it allows us to keep the same API for get_http_client

I hate that Mutex and RwLock return a Result in case they are poisoned, that's never our case and it makes their usage so cumbersome 😢

Note: I've tried to change the smallest amount of code to make the change, so the secrets manager APIs (and bitwarden-json) are still mutable. If we're okay with these changes I can go back to update those in a separate PR.

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions[bot]]

Checkmarx One – Scan Summary & Details – 7e2fdc15-9cf0-41fa-a91e-b844ec2eca82

No New Or Fixed Issues Found

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 47.31458% with 206 lines in your changes missing coverage. Please review.

Project coverage is 60.07%. Comparing base (e5a8dba) to head (46f4b2c).

Files	Patch %	Lines
crates/bitwarden-uniffi/src/auth/mod.rs	0.00%	18 Missing :warning:
crates/bitwarden-uniffi/src/tool/sends.rs	0.00%	15 Missing :warning:
crates/bitwarden/src/client/client.rs	85.29%	15 Missing :warning:
crates/bitwarden/src/auth/renew.rs	50.00%	12 Missing :warning:
crates/bitwarden-uniffi/src/crypto.rs	0.00%	11 Missing :warning:
crates/bitwarden-uniffi/src/platform/fido2.rs	0.00%	10 Missing :warning:
crates/bitwarden/src/auth/client_auth.rs	25.00%	9 Missing :warning:
crates/bitwarden-uniffi/src/tool/mod.rs	0.00%	8 Missing :warning:
crates/bitwarden-uniffi/src/vault/ciphers.rs	0.00%	8 Missing :warning:
crates/bitwarden-uniffi/src/vault/attachments.rs	0.00%	7 Missing :warning:
... and 35 more

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #837 +/- ## ========================================== + Coverage 59.22% 60.07% +0.85% ========================================== Files 186 186 Lines 12396 12246 -150 ========================================== + Hits 7341 7357 +16 + Misses 5055 4889 -166 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.