Closed dani-garcia closed 3 weeks ago
Checkmarx One – Scan Summary & Details – 651fea15-cd1b-4958-b7f6-c8ff5b6b1404
Attention: Patch coverage is 18.75000%
with 26 lines
in your changes missing coverage. Please review.
Project coverage is 60.09%. Comparing base (
07abbc7
) to head (6dff880
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🎟️ Tracking
With the mutability changes to the client, we don't need a Mutex in
bitwarden-json
anymore either, which means we can remove theasync-lock
dependency as well.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or ⚠️ (:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes