bitwarden / sdk

Bitwarden SDK.
Other
205 stars 37 forks source link

Remove Mutex from bitwarden-json #839

Closed dani-garcia closed 3 weeks ago

dani-garcia commented 3 weeks ago

🎟️ Tracking

With the mutability changes to the client, we don't need a Mutex in bitwarden-json anymore either, which means we can remove the async-lock dependency as well.

⏰ Reminders before review

🦮 Reviewer guidelines

github-actions[bot] commented 3 weeks ago

Logo Checkmarx One – Scan Summary & Details651fea15-cd1b-4958-b7f6-c8ff5b6b1404

No New Or Fixed Issues Found

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 18.75000% with 26 lines in your changes missing coverage. Please review.

Project coverage is 60.09%. Comparing base (07abbc7) to head (6dff880).

Files Patch % Lines
...s/bitwarden/src/secrets_manager/client_projects.rs 0.00% 6 Missing :warning:
...es/bitwarden/src/secrets_manager/client_secrets.rs 33.33% 6 Missing :warning:
crates/bitwarden-json/src/client.rs 0.00% 2 Missing :warning:
...s/bitwarden/src/secrets_manager/projects/create.rs 0.00% 1 Missing :warning:
...s/bitwarden/src/secrets_manager/projects/delete.rs 0.00% 1 Missing :warning:
...ates/bitwarden/src/secrets_manager/projects/get.rs 0.00% 1 Missing :warning:
...tes/bitwarden/src/secrets_manager/projects/list.rs 0.00% 1 Missing :warning:
...s/bitwarden/src/secrets_manager/projects/update.rs 0.00% 1 Missing :warning:
...es/bitwarden/src/secrets_manager/secrets/create.rs 0.00% 1 Missing :warning:
...es/bitwarden/src/secrets_manager/secrets/delete.rs 0.00% 1 Missing :warning:
... and 5 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #839 +/- ## ========================================== + Coverage 60.07% 60.09% +0.01% ========================================== Files 186 186 Lines 12246 12247 +1 ========================================== + Hits 7357 7360 +3 + Misses 4889 4887 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.