Closed Hinton closed 3 months ago
Checkmarx One â Scan Summary & Details â 9e003674-4ab4-47c2-820f-efa465ab94cd
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 60.30%. Comparing base (
32ac1e4
) to head (ecf0ddb
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
đī¸ Tracking
đ Objective
Now that we expose
ClientSettings
andDeviceType
directly in the rootbitwarden
crate we can make theclient_settings
module private. I also addedREADME
files to the newly created crates that missed them.â° Reminders before review
đĻŽ Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or âšī¸ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or đ (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or â ī¸ (:warning:
) for more significant problems or concerns needing attention:seedling:
) or âģī¸ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes