bitwarden / sdk

Bitwarden SDK.
Other
237 stars 37 forks source link

Remove calls to client_settings namespace #848

Closed Hinton closed 3 months ago

Hinton commented 3 months ago

🎟ī¸ Tracking

📔 Objective

Now that we expose ClientSettings and DeviceType directly in the root bitwarden crate we can make the client_settings module private. I also added README files to the newly created crates that missed them.

⏰ Reminders before review

đŸĻŽ Reviewer guidelines

github-actions[bot] commented 3 months ago

Logo Checkmarx One – Scan Summary & Details – 9e003674-4ab4-47c2-820f-efa465ab94cd

No New Or Fixed Issues Found

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.30%. Comparing base (32ac1e4) to head (ecf0ddb).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #848 +/- ## ======================================= Coverage 60.30% 60.30% ======================================= Files 189 189 Lines 12361 12361 ======================================= Hits 7454 7454 Misses 4907 4907 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.