Take MP reprompt into account when asserting credential

coroiu commented 1 week ago

🎟️ Tracking

📔 Objective

Take MP reprompt into account when asserting credential. If MP reprompt is enabled then we need to require UV

📸 Screenshots

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

github-actions[bot] commented 1 week ago

Checkmarx One – Scan Summary & Details – ea43fb30-be6d-4207-bc11-e42a8d1732f2

No New Or Fixed Issues Found

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 55.92%. Comparing base (d43d1cb) to head (31f271b).

Files	Patch %	Lines
crates/bitwarden-fido/src/authenticator.rs	0.00%	17 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #863 +/- ## ========================================== - Coverage 56.00% 55.92% -0.08% ========================================== Files 193 193 Lines 12607 12623 +16 ========================================== Hits 7060 7060 - Misses 5547 5563 +16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

coroiu commented 2 days ago

closing since the app will contain the MP reprompt logic for the time being

bitwarden / sdk