search

bkader / Skada-WoTLK

Skada for WoTLK, Revisited. If you have issues, suggestions or ideas, feel free to use GitHub issues or to report them on Discord.
https://discord.gg/a8z5CyS3eW
MIT License
106 stars 16 forks source link

Addon doesn't work since last commit #73

Closed Pocokk closed 2 years ago

Pocokk commented 2 years ago

Describe the bug I can't select modes (damage done, healing done, threat etc) since I've installed the last update today. I have tried to delete the cache folder, no change here.

here is the video about it, the bottom part is a separate window, it looks even worse than the default one (top). I don't know what went wrong. (when you see clicking, I tried do right mouse button)

https://streamable.com/441xdo

bkader commented 2 years ago

Can you please screenshot your addons folder as well as skada content + modules folder content? Enable LUA errors as well, without them I cannot help.

Pocokk commented 2 years ago

Message: Interface\AddOns\Skada\BarDisplay.lua:623: attempt to index local 'c' (a nil value) Time: 11/17/21 14:59:55 Count: 1 Stack: Interface\AddOns\Skada\BarDisplay.lua:623: in functionUpdate' Interface\AddOns\Skada\Skada.lua:487: in function UpdateDisplay' Interface\AddOns\Skada\Skada.lua:2148: in functionUpdateDisplay' Interface\AddOns\Skada\Skada.lua:692: in function DisplaySets' Interface\AddOns\Skada\Skada.lua:767: in functionCreateWindow' Interface\AddOns\Skada\Skada.lua:2475: in function `ReloadSettings' Interface\AddOns\Skada\Skada.lua:2956: in function <Interface\AddOns\Skada\Skada.lua:2952> (tail call): ?

(tail call): ? ...face\AddOns\Skada\Libs\AceAddon-3.0\AceAddon-3.0.lua:558: in function EnableAddon' ...face\AddOns\Skada\Libs\AceAddon-3.0\AceAddon-3.0.lua:651: in function <...face\AddOns\Skada\Libs\AceAddon-3.0\AceAddon-3.0.lua:636> [C]: in functionLoadAddOn' Interface\FrameXML\UIParent.lua:235: in function UIParentLoadAddOn' Interface\FrameXML\UIParent.lua:258: in functionCombatLog_LoadUI' Interface\FrameXML\UIParent.lua:482: in function <Interface\FrameXML\UIParent.lua:454>

Locals: self =

{ NewBarFromPrototype = defined @Interface\AddOns\Skada\Libs\SpecializedLibBars-1.0\SpecializedLibBars-1.0.lua:260 SetDefaultModuleLibraries = defined @Interface\AddOns\Skada\Libs\AceAddon-3.0\AceAddon-3.0.lua:398 NewCounterBar = defined @Interface\AddOns\Skada\Libs\SpecializedLibBars-1.0\SpecializedLibBars-1.0.lua:285 GetBarGroup = defined @Interface\AddOns\Skada\Libs\SpecializedLibBars-1.0\SpecializedLibBars-1.0.lua:657 Enable = defined @Interface\AddOns\Skada\Libs\AceAddon-3.0\AceAddon-3.0.lua:325 NewModule = defined @Interface\AddOns\Skada\Libs\AceAddon-3.0\AceAddon-3.0.lua:266 ReleaseBar = defined @Interface\AddOns\Skada\Libs\SpecializedLibBars-1.0\SpecializedLibBars-1.0.lua:293 EnableModule = defined @Interface\AddOns\Skada\Libs\AceAddon-3.0\AceAddon-3.0.lua:363 modules =
{ } GetModule = defined @Interface\AddOns\Skada\Libs\AceAddon-3.0\AceAddon-3.0.lua:241 IterateEmbeds = defined @Interface\AddOns\Skada\Libs\AceAddon-3.0\AceAddon-3.0.lua:473 BarClick = defined @Interface\AddOns\Skada\BarDisplay.lua:414 defaultModuleLibraries =
{ } BarLeave = defined @Interface\AddOns\Skada\BarDisplay.lua:221 Hide = defined @Interface\AddOns\Skada\BarDisplay.lua:189 Destroy = defined @Interface\AddOns\Skada\BarDisplay.lua:161 BarEnter = defined @Interface\AddOns\Skada\BarDisplay.lua:208 GetName = defined @Interface\AddOns\Skada\Libs\AceAddon-3.0\AceAddon-3.0.lua:310 GetBarGroups = defined @Interface\AddOns\Skada\Libs\SpecializedLibBars-1.0\SpecializedLibBars-1.0.lua:653 defaultModuleState = true IsEnabled = defined @Interface\AddOns\Skada\Libs\AceAddon-3.0\AceAddon-3.0.lua:482 orderedModules =
{ } SetTitle = defined @Interface\AddOns\Skada\BarDisplay.lua:199 DisableModule = defined @Interface\AddOns\Skada\Libs\AceAddon-3.0\AceAddon-3.0.lua:381 GetBar = defined @Interface\AddOns\Skada\Libs\SpecializedLibBars-1.0\SpecializedLibBars-1.0.lua:236 Update = defined @Interface\AddOns\Skada\BarDisplay.lua:486 baseName = "Skada" AddDisplayOptions = defined =C:-1 WindowResizing = defined @Interface\AddOns\Skada\BarDisplay.lua:905 IsModule = defined @Interface\AddOns\Skada\Libs\AceAddon-3.0\AceAddon-3.0.lua:248 ApplySettings = defined @Interface\AddOns\Skada\BarDisplay.lua:782 SetDefaultModuleState = defined @Interface\AddOns\Skada\Libs\AceAddon-3.0\AceAddon-3.0.lua:418 IsShown = defined @Interface\AddOns\Skada\BarDisplay.lua:195 OnMouseWheel = defined @Inte`

https://imgur.com/a/a2No4ys

bkader commented 2 years ago

You obviously have corrupted/wrong/missing stuff in your SavedVariables, that's why you have this error. Delete all your windows and create new ones. Meanwhile, I will push a small check so people won't have the same error you had.

Pocokk commented 2 years ago

Thank you.

But how that happened? Just hours ago it was fine, installing the newest version shouldn't have done that, no?

bkader commented 2 years ago

I don't know how it was caused, if you check skada defaults you will see that textcolor is there, and your window was missing that key for some reason, maybe you had a window using BrokerDisplay or something, I really don't know, unless I know what you exactly did, I mean in the settings. For now, try to update or delete your windows and see if your problem is fixed.

Pocokk commented 2 years ago

I've been using the same settings/windows options since 2019, will try and update them then.

Pocokk commented 2 years ago

Another lua error when clicking on the "mode" button at the top of the bar

Message: ...s\Skada\Libs\LibUIDropDownMenu\LibUIDropDownMenu.lua:268: attempt to index local 'info' (a nil value) Time: 11/17/21 15:48:20 Count: 2 Stack: ...s\Skada\Libs\LibUIDropDownMenu\LibUIDropDownMenu.lua:268: in function <...s\Skada\Libs\LibUIDropDownMenu\LibUIDropDownMenu.lua:267> Interface\AddOns\Skada\Menus.lua:720: in functioninitFunction' ...s\Skada\Libs\LibUIDropDownMenu\LibUIDropDownMenu.lua:87: in function L_UIDropDownMenu_Initialize' ...s\Skada\Libs\LibUIDropDownMenu\LibUIDropDownMenu.lua:971: in function <...s\Skada\Libs\LibUIDropDownMenu\LibUIDropDownMenu.lua:833> Interface\AddOns\Skada\Menus.lua:758: in functionModeMenu' Interface\AddOns\Skada\BarDisplay.lua:101: in function <Interface\AddOns\Skada\BarDisplay.lua:101>

Locals: info = nil level = 1 (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = "attempt to index local 'info' (a nil value)"`

bkader commented 2 years ago

I see. So you either disabled all modules or deleted them. Otherwise, the error shouldn't have happened. Anyways, again, I implemented a quick fix so people doing that won't encounter the same error.

Pocokk commented 2 years ago

Thanks for the quickfix!

Yes I did disable SOME modules because I don't use them, but didn't delete any of them manually from the folder.

https://imgur.com/a/dwlOFud

This issue was very weird, but after installing the latest commit, its working fine, now I just have to re-setup the windows settings :D

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.