Spacing between icons and menu-items in main menu is missing on macOS

black7375 / Firefox-UI-Fix

🦊 I respect proton UI and aim to improve it.

Mozilla Public License 2.0

5.35k stars 187 forks source link

Closed kevinboss closed 3 years ago

kevinboss commented 3 years ago

Describe the bug No spacing between menu entry and icon in main menu, see also:

Expected behavior The same space as in all other menus, see for example the addon overflow menu:

Environment (please complete the following information):

Additional context Love your work, I love the course Mozilla is taking with proton now.

black7375 commented 3 years ago

I haven't been able to test it on a mac. (Broke down 2 years ago)

However, it takes a lot of time, but I have found a way, and I will test it within this week. https://github.com/sickcodes/Docker-OSX

There are many bugs in the Mac, such as padding and fill color.. Thanks to report

black7375 commented 3 years ago

Debug Tutorial

Main Part of Icons

black7375 commented 3 years ago

Unlike the previous experience, Docker for OS X installation did not work as expected, and it was temporarily predicted and corrected.

Are there any changes?

kevinboss commented 3 years ago

The icons have been fixed, looks fine now. However it seems to have introduced an issue with the icon in front of the account menu-item, see:

black7375 commented 3 years ago

OK, I got confidence.

I'll fix it right away.

Hope it is fixed.

kevinboss commented 3 years ago

Now it is perfect.

Btw. is there some way to gift you a cup of coffee?

black7375 commented 3 years ago

I have a contract to prohibit external revenue until next year.

You don’t need to get me anything. Thank you!!