black7375 / Firefox-UI-Fix

🦊 I respect proton UI and aim to improve it.
Mozilla Public License 2.0
5.4k stars 188 forks source link

Port install script to Powershell #119

Closed jupjohn closed 3 years ago

jupjohn commented 3 years ago

Is your feature request related to a problem? Please describe. The current install script is written in bash - preventing it from being run on most Windows-based machines without the use of git-bash/WSL.

Describe the solution you'd like The install script should be ported to Powershell (as part of v3) for Windows installations.

Describe alternatives you've considered -none

Additional context Wanted an issue for tracking against the v3 "powershell script" milestone. Happy to take a dig at implementing it.

ghost commented 3 years ago

109

Won't be easy since powershell isn't as powerfull as bash.

ojaha065 commented 3 years ago

powershell isn't as powerfull as bash

This is very much not true. While personally I'm not a huge fan of PowerShell, everything that can be done using Bash, can also be done just as easily in PowerShell.

ghost commented 3 years ago

Ok..Maybe I should try to study it deeper.

jupjohn commented 3 years ago

Won't be easy since powershell isn't as powerfull as bash.

You'll find that PS has a lot more power with .NET behind it. Everything done in the current bash install script can be done in PS just fine. I'll create a draft PR with the prototype if you'd like to see how it works.

ghost commented 3 years ago

Oh maybe that's the reason I felt powershell wasn't powerful enough. But do you need the .NET framework runtime to run .NET commands in powershell?

theseer commented 3 years ago

While I have to admit my days of writing extensions for Firefox date back to when chrome and XUL where still a thing: Why don't we create an actual extension to install things?

black7375 commented 3 years ago

I've been using Bash for a long time, but I've rarely used PowerShell. It will probably have to be made by trial and error. (Having a prototype would be of great help.) I know that powershell, not cmd, has enough features, so it will be possible to implement.

There is one nice tool that was recently introduced. I will move towards using ewen-lbh/ffcss, but it doesn't seem to support the upgrade process yet. So, for the time being, a script will be needed, but since it seems likely that functions such as upgrade/GUI/autoconfig(userChromeJS) will be included, I am thinking of switching at any time.

With one unified manager, I can spend more time fixing bugs or developing features.


tldr; I will release powershell script in this version, but I have to go in the direction of using ffcss.

ojaha065 commented 3 years ago

@theseer

Why don't we create an actual extension to install things?

It's just not possible anymore. WebExtensions API is very limited (especially if compared to XUL) when it comes to editing the browser UI. See #47 .

theseer commented 3 years ago

Sigh Thanks.

jupjohn commented 3 years ago

Created #122 for implementation.

black7375 commented 3 years ago

Experimental powershell script is merged.