black7375 / Firefox-UI-Fix

🦊 I respect proton UI and aim to improve it.
Mozilla Public License 2.0
5.41k stars 188 forks source link

[Discussion] Video Player Design #335

Closed black7375 closed 2 years ago

black7375 commented 2 years ago

Hello, the next version is planning to add 1 to 2 features, and one of them is a video design.

Original

As you can see, it looks stuffy.

image

One Line Concept

I changed the background to look transparent.

image

Two Line Concept

I adjusted it to two lines like YouTube.

image


Which one do you prefer? Please express it with an emoji.

The comments are good, too.

black7375 commented 2 years ago

Thank you all. Then I'll work based on the second style.

PS. Try the following code to get the third style.

/* Second Line */
#controlsContainer .controlBar {
  flex-wrap: wrap;
  justify-content: space-between;
  align-content: space-around;
  height: calc(var(--controlBar-height) + var(--thumb-size)) !important;
  padding-inline: 0 !important; /* Original: 9px */
}
#controlsContainer .scrubberStack {
  /* Vertical */
  order: -1;
  height: var(--thumb-size) !important;
  transform: translateY(calc(var(--thumb-size) / 2));

  /* Horizontal */
  flex-basis: auto !important;
  width: 100%;
  margin-inline: 0 !important;
}
#controlsContainer .positionDurationBox {
  flex-grow: 2;
  margin-left: 15px !important;
  text-align: left !important;
}
#playButton {
  margin-left: 9px !important;
}
#fullscreenButton {
  margin-right: 9px !important;
}
#controlsContainer .duration {
  color: #dadada !important; # /* Original: #929292 */
}
black7375 commented 2 years ago

Video Test

https://user-images.githubusercontent.com/25581533/200356463-71419772-e0f1-4e9b-b5ef-68a885f1e2ad.mp4

https://user-images.githubusercontent.com/25581533/200356518-9457131c-e9be-42cf-8078-fe27ce8d5a36.mp4

JohnyP36 commented 2 years ago

Thank you all. Then I'll work based on the second style.

PS. Try the following code to get the third style.

/* Second Line */
#controlsContainer .controlBar {
  flex-wrap: wrap;
  justify-content: space-between;
  align-content: space-around;
  height: calc(var(--controlBar-height) + var(--thumb-size)) !important;
  padding-inline: 0 !important; /* Original: 9px */
}
#controlsContainer .scrubberStack {
  /* Vertical */
  order: -1;
  height: var(--thumb-size) !important;
  transform: translateY(calc(var(--thumb-size) / 2));

  /* Horizontal */
  flex-basis: auto !important;
  width: 100%;
  margin-inline: 0 !important;
}
#controlsContainer .positionDurationBox {
  flex-grow: 2;
  margin-left: 15px !important;
  text-align: left !important;
}
#playButton {
  margin-left: 9px !important;
}
#fullscreenButton {
  margin-right: 9px !important;
}
#controlsContainer .duration {
  color: #dadada !important; # /* Original: #929292 */
}

In which file do I have to add/change this?

black7375 commented 2 years ago

I was taking notes for the link I needed during the documentation.


You can just take userContent.player.ui.twoline to true. & Restart https://github.com/black7375/Firefox-UI-Fix/wiki/Options#two-line