search

black7375 / Firefox-UI-Fix

🦊 I respect proton UI and aim to improve it.
Mozilla Public License 2.0
5.32k stars 187 forks source link

Photon-styled navigation button doesn't work #671

Closed ryenyuku closed 1 year ago

ryenyuku commented 1 year ago

Describe the bug

Applying userChrome.combined.nav_button along with userChrome.combined.sub_button.as_normal does not give the expected photon-ish navigation button appearance and instead will still combine the back and forward navigation button.

Expected behavior

Give the photon-ish navigation button just like in #511 at the "Photon with multirow" section.

Screenshots

No response

OS

Linux

OS - Others

No response

Firefox Version

111.0.1

Distribution

Theme

Theme - More Info

Matte Black Green

user.js setup

user.js setup
```javascript // == Theme Distribution Settings ============================================== user_pref("userChrome.tab.connect_to_window", true); // Original, Photon user_pref("userChrome.tab.color_like_toolbar", true); // Original, Photon user_pref("userChrome.tab.lepton_like_padding", false); // Original user_pref("userChrome.tab.photon_like_padding", true); // Photon user_pref("userChrome.tab.dynamic_separator", false); // Original, Proton user_pref("userChrome.tab.static_separator", true); // Photon user_pref("userChrome.tab.static_separator.selected_accent", false); // Just option user_pref("userChrome.tab.newtab_button_like_tab", false); // Original user_pref("userChrome.tab.newtab_button_smaller", true); // Photon user_pref("userChrome.tab.newtab_button_proton", false); // Proton user_pref("userChrome.icon.panel_full", false); // Original, Proton user_pref("userChrome.icon.panel_photon", true); // Photon // Original Only user_pref("userChrome.tab.box_shadow", false); user_pref("userChrome.tab.bottom_rounded_corner", false); // Photon Only user_pref("userChrome.tab.photon_like_contextline", true); user_pref("userChrome.rounding.square_tab", true); // == Theme Custom Settings ==================================================== // -- User Chrome -------------------------------------------------------------- user_pref("userChrome.decoration.panel_button_separator", true); user_pref("userChrome.decoration.panel_arrow", true); user_pref("userChrome.combined.nav_button", true); user_pref("userChrome.combined.sub_button.as_normal", true); user_pref("userChrome.padding.urlView_expanding", true); user_pref("userChrome.padding.urlView_result", true); user_pref("userChrome.padding.toolbar_button.compact", true); user_pref("userChrome.urlView.always_show_page_actions", true); user_pref("userChrome.urlView.move_icon_to_left", true); user_pref("userChrome.rounding.square_panel", true); user_pref("userChrome.rounding.square_panelitem", true); user_pref("userChrome.panel.full_width_separator", true); user_pref("userChrome.panel.full_width_padding", true); ```

Additional context

No response

ryenyuku commented 1 year ago

Looks like the culprit is in https://github.com/black7375/Firefox-UI-Fix/blob/master/css/leptonChrome.css#L8186 where an incorrect check is being done, and will only give the photon-ish nav button if userChrome.combined.urlbar.home_button is enabled too

black7375 commented 1 year ago

Thank you for waiting. I just updated.

black7375 commented 1 year ago

Try to use new version please!!

ryenyuku commented 1 year ago

Try to use new version please!!

Yeah, the latest version fixed it. Thanks for the patch 👍🏻