black7375 / Firefox-UI-Fix

🦊 I respect proton UI and aim to improve it.
Mozilla Public License 2.0
5.32k stars 187 forks source link

Add: Rounding - Square infoboxes #677

Closed ricewind012 closed 1 year ago

ricewind012 commented 1 year ago

Describe the PR adds the userChrome.rounding.square_infobox option

PR Type

Related Issue

645 #618 #616

Aleksandra0056 commented 1 year ago

Thank you, you are doing nice work. To be honest, you are an excellent CSS programmer.

ricewind012 commented 1 year ago

I barely did anything

ricewind012 commented 1 year ago

I don't know, putting content's infobox in field makes no sense to me, as field, for me, is something that takes input from the user

Aleksandra0056 commented 1 year ago

I don't want to be rude, but Mr. 2641a40 is right. Putting infobox into field makes no sense also for me.

Aleksandra0056 commented 1 year ago

By the way, this PR fixes also this? The warning tooltip in the Clear All History isn't supporting square corners

Just correct me if I'm not right, because it is unclearly written (in the PR description) what would be fixed.

black7375 commented 1 year ago

To explain my point of view, I focused on whether the user would use it together rather than the property. It is not bad to think of it as a forbidden field to write, as if you can't modify the ID of the site after signing up.

For example, the following is a field that looks like infobox but is writable.

image

image

image

ricewind012 commented 1 year ago

By the way, this PR fixes also this?

yes

the following is a field that looks like infobox but is writable

I see, do I move them to field ?

black7375 commented 1 year ago

Yes I believe that is better

and make notification bar(.container.infobar) as userChrome.rounding.square_toolbar.

I think userChrome.rounding.square_toolbar would be good as a name to support userChrome.tabbar.one_liner or userChrome.findbar.floating_on_top later.

Aleksandra0056 commented 1 year ago

Mr. 2641a40, I think, that it would better if you listen to Mr. black7375, because he is requesting some changes.

No offence, I'm just thinking out loud.

ricewind012 commented 1 year ago

so .container.infobar will become userChrome.rounding.square_toolbar and others will be left alone, right ?

Aleksandra0056 commented 1 year ago

Sorry, but you are talking to me? Or to Mr. black7375? I think, that it would be better if you mention with @ sign.

In example: @Patricek0056

ricewind012 commented 1 year ago

forgot, but @black7375

Aleksandra0056 commented 1 year ago

And, it is under what option? Under userChrome.rounding.square_toolbar, or under userChrome.rounding.square_infobox?

black7375 commented 1 year ago

I'll change it later. (userChrome's notification bar)