Closed ricewind012 closed 1 year ago
Thank you, you are doing nice work. To be honest, you are an excellent CSS programmer.
I barely did anything
I don't know, putting content's infobox in field makes no sense to me, as field, for me, is something that takes input from the user
I don't want to be rude, but Mr. 2641a40 is right. Putting infobox into field makes no sense also for me.
By the way, this PR fixes also this?
Just correct me if I'm not right, because it is unclearly written (in the PR description) what would be fixed.
To explain my point of view, I focused on whether the user would use it together rather than the property. It is not bad to think of it as a forbidden field to write, as if you can't modify the ID of the site after signing up.
For example, the following is a field that looks like infobox but is writable.
By the way, this PR fixes also this?
yes
the following is a field that looks like infobox but is writable
I see, do I move them to field ?
Yes I believe that is better
and make notification bar(.container.infobar) as userChrome.rounding.square_toolbar.
I think userChrome.rounding.square_toolbar would be good as a name to support userChrome.tabbar.one_liner or userChrome.findbar.floating_on_top later.
Mr. 2641a40, I think, that it would better if you listen to Mr. black7375, because he is requesting some changes.
No offence, I'm just thinking out loud.
so .container.infobar
will become userChrome.rounding.square_toolbar
and others will be left alone, right ?
Sorry, but you are talking to me? Or to Mr. black7375? I think, that it would be better if you mention with @ sign.
In example: @Patricek0056
forgot, but @black7375
And, it is under what option? Under userChrome.rounding.square_toolbar
, or under userChrome.rounding.square_infobox
?
I'll change it later. (userChrome's notification bar)
Describe the PR adds the
userChrome.rounding.square_infobox
optionPR Type
Add:
Add feature or enhanced.Fix:
Bug fix or change default values.Clean:
Refactoring.Doc:
Update docs.Related Issue
645 #618 #616