black7375 / Firefox-UI-Fix

🦊 I respect proton UI and aim to improve it.
Mozilla Public License 2.0
5.36k stars 187 forks source link

F11 + extensions menu #701

Closed PhoenixIndigo closed 3 months ago

PhoenixIndigo commented 1 year ago

Describe the bug

When you press the F11 with an open menu extension, the menu disappears, and the button remains busy and does not change if it is on the panel! При нажатии F11, при открытом меню расширения, меню исчезает, а кнопка остаётся занятой и не меняется если она на панели!

Expected behavior

No response

Screenshots

Details

![](https://github.com/black7375/Firefox-UI-Fix/assets/107413021/84c2a65b-d6d8-4394-bdf7-2d9a7e0707ed)

OS

Windows 10

OS - Others

No response

Firefox Version

113.0.1

Distribution

Theme

Theme - More Info

https://addons.mozilla.org/ru/firefox/addon/violet-kawai/ https://addons.mozilla.org/ru/firefox/addon/cloudy-grey/

user.js setup

user.js setup
```javascript ```

Additional context

No response

Aleksandra0056 commented 1 year ago

Why did you post the issue description in Russian (Or Bulgarian, Serbian)?

Mr. black7375 and other GitHub people are not understanding the Russian language. In example, I'm a native Slovak speaker, and I'm not posting my issues with Slovak language.

Just correct me if your issue is in Russian, Serbian, or Bulgarian (because it is almost the same), but you should write it only with English, because it is useless for most English, Korean, or other people in GitHub.

Also, if you post issue/discussion/pull request in languages other than English, then it is maybe considered as spam by GitHub staff (but short lines with some words are not considered as a spam, I think).

But if you really want to post issues in Russian, then add it as a second behind the English description, and not as the first. This may have an advantage, e.g. if your friends, or family don't know English, then you can write it in Russian, but write it behind the English and not before the English.

I'm not saying, that you should remove it, but edit the issue and swap the languages places (First English, and Second Russian should be in issue description).

Thank you for understanding my opinion.

PhoenixIndigo commented 1 year ago

When you press the F11 with an open menu extension, the menu disappears, and the button remains busy and does not change if it is on the panel!

I left the translation, if he is incomprehensible, then tell me!

black7375 commented 1 year ago

I've figured out the cause.

https://github.com/black7375/Firefox-UI-Fix/blob/3058069e0ae76614ffbd1cb166997ec79807a078/src/fullscreen/_overlap.scss#L2


This code is applied to prevent the toolbar from taking up space in fullscreen. It's reproducible, but not easy to fix.

This is a temporary solution. userChrome.fullscreen.overlap set to false at user.js https://github.com/black7375/Firefox-UI-Fix/blob/3058069e0ae76614ffbd1cb166997ec79807a078/user.js#L250