black7375 / Firefox-UI-Fix

🦊 I respect proton UI and aim to improve it.
Mozilla Public License 2.0
5.26k stars 184 forks source link

Could Firefox UI FIX Support Floorp ? #710

Closed surapunoyousei closed 1 year ago

surapunoyousei commented 1 year ago

Is your feature request related to a problem?

Floorp's code is proprietary, and some codes are missing, so Floorp makes additions and adjustments.

The solution I'd like

I don't want to force you to do this, but I would appreciate it if you could add the specific code.

My solution would be to create CSS that loads when Floorp-specific settings are enabled.

Screenshots or video

image

Alternatives I've considered

Modify by Floorp's developer

Additional context

No response

black7375 commented 1 year ago

Can I see what code it is? I think it can be supported if it doesn't cause side effects to Firefox.

Even if there is a side effect, there is a way. As far as I know, waterfox has its own media query. If you have a media query or a unique about:config value that runs only on Floorp, you can show it correctly.

surapunoyousei commented 1 year ago
  #usercssloader-menu {
    --menuitem-image: url("chrome://browser/skin/lepton/developer.svg");
  }
  #rebootappmenu {
    list-style-image: url("chrome://browser/skin/lepton/refresh-cw.svg");
  }
  #openprofiledir {
    list-style-image: url("chrome://browser/skin/lepton/folder.svg");
  }

We need this CSS

Floorp has its own status bar implemented by Floorp, but without icons. Because I don't have the technology to create icons, which is embarrassing.

black7375 commented 1 year ago

Of course. This project also provides icons of waterfox or tor browser.

I'll add the above code tomorrow.


For the icons, I've added them from the following sources. (Although they are modified and used in size and color)

surapunoyousei commented 1 year ago

Thank you.

surapunoyousei commented 1 year ago

Floorp 11 has a native implementation of vertical tabs. Please let me know if there is anything you don't like about the design. Rework with respect to Firefox UI Fix

black7375 commented 1 year ago

Added support for Floorp. Where can I try Floorp 11?

surapunoyousei commented 1 year ago

https://github.com/surapunoyousei/Floorp/actions/runs/5295413586

This is Actions run. you can download app

windows: https://github.com/surapunoyousei/Floorp/suites/13670804810/artifacts/755499185 mac: https://github.com/surapunoyousei/Floorp/suites/13670804810/artifacts/755499186 linux aarch64: https://github.com/surapunoyousei/Floorp/suites/13670804810/artifacts/755499180 linux 86_64: (preparing)

black7375 commented 1 year ago

Feedback

Workspace and Vertical tabbar are very cool !! Browser content rounding looks like Edge and Arc browser, is also impressive.

Here are some feedback:

1. Vertical tabbar supports

There is a problem with the bottom round of the tab, so I added a code for compatibility. https://github.com/black7375/Firefox-UI-Fix/commit/3058069e0ae76614ffbd1cb166997ec79807a078

2. Sidebar

Firefox's sidebar feature was not available.

I'am try to these addons:

3. Button background color

The background color of the button is too dark when the system default theme.

image

4. Extension page

I think it would be consistent if the side menu had a bar like General in the settings.

image image

5. Panel Setting

If you set userChrome.icon.full to true, set userChrome.icon.panel_photon to false. If both are true, problems may occur in some layouts.

https://github.com/surapunoyousei/Floorp/blob/3da07d5fe6715309b1f40c899d4e8db146f07968/floorp/browser/app/profile/000-floorp.js#L345

6. Workspace Name

Putting the space seems to have a problem.

surapunoyousei commented 1 year ago

I see. I use Dark mode. I didn't test it. we are sry.

  1. Vertical tabbar supports:

Thanks !

  1. Sidebar

If you use verticaltabbar, Cannot use sidepanel addons.

  1. Extension page

I will add it.

  1. Panel Setting

I will change default preferences.

  1. Workspace Name

    " " is disabled because they could cause elements to be generated. I will reconsider.

surapunoyousei commented 1 year ago

I've identified a few issues and will work to fix them!

Thank you for your feedback.

black7375 commented 1 year ago

I'm really enjoying the experience, great project! Please tell me if you need anything in this project.

surapunoyousei commented 1 year ago

Fixed !

black7375 commented 1 year ago

Quick commit!! Thanks.

surapunoyousei commented 1 year ago

Thank you for v7.4.0 Release, I will replace Floorp's file.

Illusiveman931 commented 4 months ago

Floorp's code is proprietary

I thought Floorp free and opensource isn't it?

black7375 commented 4 months ago

@Illusiveman931 Yes. floorp browser is opensource. https://github.com/Floorp-Projects/Floorp

Illusiveman931 commented 4 months ago

you are right but I just don't understand why the main developer of floorp made this confusing statement

black7375 commented 4 months ago

In the past, Lepton had some problems because it did not consider compatibility and icons for floorp.

We are now well supported through cooperation with the floorp maintainer.

Illusiveman931 commented 4 months ago

thanks for the answer, even if it doesn’t explain surapunoyousei’s statement, I guess it's not that important, sorry for disturbing you