black7375 / Firefox-UI-Fix

🦊 I respect proton UI and aim to improve it.
Mozilla Public License 2.0
5.26k stars 184 forks source link

Missing icons at Manage Bookmark & History Library #739

Closed Progress200 closed 11 months ago

Progress200 commented 1 year ago

Describe the bug

At Manage Bookmark & History Library (Open by pressing Ctrl+Shift+O), the Redo and Restore icons are missing.

Expected behavior

The Redo and Restore icons are present to make the UI more consistent.

Screenshots

Screenshot 2023-07-07 122335 Screenshot 2023-07-07 122344

OS

Windows 11

OS - Others

No response

Firefox Version

v117.0a1

Distribution

Theme

Theme - More Info

No response

user.js setup

user.js setup
```javascript // Your settings ```

Additional context

No response

black7375 commented 1 year ago

The redo menu is an intentional decision as empty looks better than stuffed.

image

If do you want, set


Restore could not find a suitable icon, so it probably doesn't exist yet.

Progress200 commented 1 year ago

Even I follow your guide, the restore icon is still missing. image

black7375 commented 11 months ago

I've added icons. I released it, so check it out !!

Progress200 commented 11 months ago

I tried on the newest release and the icon still doesn't appear. (Firefox 118.0a1, Lepton v7.50 with #744 quick fix) image

black7375 commented 11 months ago

@Progress200 Can you check followings?

  1. userChrome.icon.menu.full to true
  2. <PROFILE_PATH>/chrome/icons/datarestore.svg is exist https://github.com/black7375/Firefox-UI-Fix/commit/276510d732ec447543aeaf5ce063df65c1dff93b#diff-093c15cbf08255fc91625b98349e24f1e0c9806099fe8f3f806382a79764da98

image image

Progress200 commented 11 months ago

I set userChrome.icon.menu.full to true and it works now. Thank you!