search

black7375 / Firefox-UI-Fix

🦊 I respect proton UI and aim to improve it.
Mozilla Public License 2.0
5.26k stars 184 forks source link

Multiple UI Bugs after updated to v117.0a1 (Nightly) #744

Closed Progress200 closed 10 months ago

Progress200 commented 12 months ago

Describe the bug

I have discovered two different UI bugs after upgraded to Nightly v117.9a1.

  1. When theme is being set to System Theme. Firefox no longer show the MS edge inspired theme instead showing the light/dark theme. image
  2. The UI of the pop up and container selection box is buggy.

image image

Expected behavior

Work as what normally Lepton would behave.

Screenshots

No response

OS

Windows 11

OS - Others

No response

Firefox Version

v117.0a1 (Nightly)

Distribution

Theme

Theme - More Info

No response

user.js setup

user.js setup
```javascript // Your settings ```

Additional context

No response

black7375 commented 12 months ago

I checked briefly and it seems like a problem with the media query.

It works

@media (-moz-platform: windows) {
}

But it doesn't works

@media (-moz-platform: windows-win10) {
}

It seems to be a Firefox problem and needs to understand why it happened. I'll create an upstream issue.

black7375 commented 12 months ago

Gone is the way to distinguish between Windows versions.

We need to see if there's a way to do it.

ctrlcmdshft commented 11 months ago

Same issue on FF117.0b2 on Windows 11, Hopefully your able to push a fix soon

black7375 commented 11 months ago

This will be a breaking change and should be discontinued support for windows7 and windows8. Maybe we have to release a new major version.

ctrlcmdshft commented 11 months ago

Is there a way i can manually fix this (the context menu icon/text overlap)

MagicalDrizzle commented 11 months ago

This will be a breaking change and should be discontinued support for windows7 and windows8. Maybe we have to release a new major version.

It might be nice to dedicate 7.x.x for 115esr (last version to support w7 and 8), and 8.x.x for future versions going forward

black7375 commented 11 months ago

Is there a way i can manually fix this (the context menu icon/text overlap)

It might be nice to dedicate 7.x.x for 115esr (last version to support w7 and 8), and 8.x.x for future versions going forward

I'll do some tests and release this weekend.

ctrlcmdshft commented 11 months ago

Is there a way i can manually fix this (the context menu icon/text overlap)

* Replace `(-moz-platform: windows-win10)` to `(-moz-platform: windows)` at `css/leptonChrome.css`/`css/leptonContent.css`

It might be nice to dedicate 7.x.x for 115esr (last version to support w7 and 8), and 8.x.x for future versions going forward

I'll do some tests and release this weekend.

Changed every instance of (-moz-platform: windows-win10) to (-moz-platform: windows) in both files and still have issue

Evo-c commented 11 months ago

Is there a way i can manually fix this (the context menu icon/text overlap)

* Replace `(-moz-platform: windows-win10)` to `(-moz-platform: windows)` at `css/leptonChrome.css`/`css/leptonContent.css`

It might be nice to dedicate 7.x.x for 115esr (last version to support w7 and 8), and 8.x.x for future versions going forward

I'll do some tests and release this weekend.

Changed every instance of (-moz-platform: windows-win10) to (-moz-platform: windows) in both files and still have issue

One alternative is to temporarily disable the icons, in leptonChrome search for background-size: 16px !important; and change it to 0px

Edit: Also managed to find an easy quick fix to get the icons working, remove lines 10912 to 10918 (including the closing brackets), then find #context_openANewTab.tabmix-newtab-menu-icon { and change padding-inline-start: 0px !important; to 30px

It's certainly a scruffy way to do it, but it's quick, easy and works.

ctrlcmdshft commented 11 months ago

Thanks i used first one to do it for time being

black7375 commented 11 months ago

Hello, I just opened the PR. The following files should work normally!!

Would you like to test?

ctrlcmdshft commented 11 months ago

Working again after replacing the files

Thank you

black7375 commented 10 months ago

Firefox 117 seems to work well after its launch, so it closes. However, since many people are expected to find an issue, the pinned is maintained for the time being.