black7375 / Firefox-UI-Fix

🦊 I respect proton UI and aim to improve it.
Mozilla Public License 2.0
5.26k stars 184 forks source link

Right click menu of Tree Style Tab no longer has separators - broken in FF116+ #758

Closed MagicalDrizzle closed 10 months ago

MagicalDrizzle commented 10 months ago

Describe the bug

(FF116+)

  1. Install Tree Style Tab.
  2. Right click the vertical tab to bring up the menu.
  3. Separators no longer appears.

Expected behavior

(FF115-) Separator appears.

Screenshots

116115

left is 116.0, right is 115.0.3

OS

Windows 10

OS - Others

No response

Firefox Version

v116.0

Distribution

Theme

Theme - More Info

No response

user.js setup

Unchanged from the user.js distributed with v8.0.0

Additional context

No response

black7375 commented 10 months ago

The confirmation has changed the structure so that the sidebar content is isolated. First of all, I worked briefly on separator, but in the long run, there are things I need to work on again so that the color of the sidebar context menu works with the theme.

AuRiMaS666 commented 10 months ago

This is probably related to this, so I'll just add to this thread, instead of opening a new one.

There's no separators at all when right clicking items in the Library window. And, as mentioned by the OP, Sidebar separator colors are not right, they're too dark to match the background. When right clicking items directly on the Bookmarks Toolbar or using the dropdown menu, everything is displayed correctly.

This is on Win11, Firefox v117, it was the same on v116 as well.

2023-08-29 11 22 26 2023-08-29 11 19 58

black7375 commented 10 months ago

It was a smaller task than I thought. Now it should work correctly. Could you test it?

AuRiMaS666 commented 10 months ago

Seems to work fine now, thanks!

2023-09-03 13 05 51 2023-09-03 13 06 59

black7375 commented 10 months ago

@AuRiMaS666 Thank you for fast feedback!!