black7375 / Firefox-UI-Fix

🦊 I respect proton UI and aim to improve it.
Mozilla Public License 2.0
5.24k stars 184 forks source link

Remove Set as Desktop Background context menu items causes double separators to appear #764

Closed MagicalDrizzle closed 10 months ago

MagicalDrizzle commented 10 months ago

Describe the bug

Remove Set as Desktop Background context menu items causes double separators to appear. This is because Set as Desktop Background is separated from all the rest with two separators. Thus removing it cause two separators to appear.

This appears to be an oversight because this specific modification is included in the userChrome.css file.

/* Disable Email Image/Audio/Video and Set as Desktop Background context menu items */
/*
 * #context-sendimage,
 * #context-sendvideo,
 * #context-sendaudio,
 * #context-setDesktopBackground {
 *   display: none !important;
 * }
*/

Expected behavior

There should only be one separator.

Screenshots

28-08-23_13-59_file-3428-08-23_14-02_file-35

OS

Windows 10

OS - Others

No response

Firefox Version

v116.0.3

Distribution

Theme

Theme - More Info

No response

user.js setup

Unchanged from default.

Additional context

No response

AuRiMaS666 commented 10 months ago

Yes, this needs to be hidden together with its dedicated separator.

https://github.com/stonecrusher/simpleMenuWizard/blob/12375ead3f48761456a6833fe1317ca07c8edf9f/simpleMenuWizard/image-context.css#L17C1-L18C75

black7375 commented 10 months ago

Since #765 has been merged, I think this issue has been solved.