Photon - missing active tab highlight

[evinnichenko]

Describe the bug

Selected tab is not highlighted with brighter background (e.g. with light grey on light theme)

Expected behavior

Selected tab stands out with different color (part of a screenshot from Lepton's page, default Photon style, dark theme)

Screenshots

OS

Windows 10

OS - Others

No response

Firefox Version

121

Distribution

• [ ] Original Lepton
• [X] Lepton's photon style
• [ ] Lepton's proton style

Theme

• [X] Light
• [ ] Dark
• [ ] Alpenglow (System: Light)
• [ ] Alpenglow (System: Dark)
• [X] System Default
• [ ] Others: (e.g. Photon Colors, Google Chrome Dark, Fairytale Of Nature)

Theme - More Info

No response

user.js setup

Default settings

Additional context

No response

[Ziedge]

I can confirm the bug since it's happening on my computer too

[russellweed]

I can confirm this as well. It started happening today

Original Lepton Leptop version: Latest as of 2023-12-20 Firefox version 121.0 Windows 11 Pro 23H3

[black7375]

@Ziedge @russellweed This issue can be related #827 #828

[Farmbuyer]

Yep, 8.50 under FF120.0.something was fine, upgrade to FF121.0 loses the tab highlight. It's still present in private windows, however.

[mikesafari]

@Ziedge @russellweed This issue can be related #827 #828

Certainly looks like it. Is there a workaround until a fix is published?

[Farmbuyer]

@Ziedge @russellweed This issue can be related #827 #828

Certainly looks like it. Is there a workaround until a fix is published?

From the comments in #827 the fix may already be published in the sense that FF 121.something will behave correctly again (unless I've misinterpreted the comment thread). In the meantime, going to about:config, finding userChrome.tab.photon_like_contextline in the search box, and toggling to true will get an active tab highlight (although it's not the one we'd get from FF120).

It's possible to make the same change stick by going to the profile folder* and editing user.js; the same setting is around line number 47 if it's an unmodified user.js from Lepton 8.5.0. Obviously this file will be replaced when a new version of Lepton is dropped in, so there's no worry about having to undo the change manually.

* about:support, find the profile folder entry, click open folder

[black7375]

Hello, I believe the issue is resolved in v8.5.1.

[Ziedge]

Hello, I believe the issue is resolved in v8.5.1.

It is indeed ! Thanks again for everything !

[black7375]

I've been a little busy with work lately, so I've been a little behind. Instead, in the next release, I'll share an article I wrote over Christmas!!

[mikesafari]

Hello, I believe the issue is resolved in v8.5.1.

Doesn't seem to be for me... 🤔

I used the PowerShell installation (as normal) and an update finds nothing new and re-doing either Photon or Proton style still seems to result in an incorrect highlight.

[russellweed]

@mikesafari

It did work for me. The trick was to completely remove the old copy of Photon first. Nuke your userChrome, icons folder, and the user.js. Also, I did a manual install and did not use the PowerShell script (no idea if that has anything to do with it).

[mikesafari]

@mikesafari

It did work for me. The trick was to completely remove the old copy of Photon first. Nuke your userChrome, icons folder, and the user.js. Also, I did a manual install and did not use the PowerShell script (no idea if that has anything to do with it).

I guess I should clarify that I normally use the Proton-style branch. For now I've switched back to the main branch because it works but the Proton-style one is still broken.

Not a huge deal tbh, but would be nice to get the updates into that branch as well.

[Farmbuyer]

Manually removing previous Lepton installation before updating to 121+8.5.1 fixed it here as well.

Cheers!