search

black7375 / Firefox-UI-Fix

🦊 I respect proton UI and aim to improve it.
Mozilla Public License 2.0
5.24k stars 184 forks source link

Missing icons on menu bar context menu (Copy Without Site Tracking, Paste and Go) #873

Closed happy-dude closed 4 months ago

happy-dude commented 4 months ago

Describe the bug

After copying a link and right clicking the menu bar, two options lack corresponding icons:

Expected behavior

Icons appears for the menu-bar-right-click context menu:

Copy Without Site Tracking reuses the same icon from right-clicking a link in a web page

Screenshots

Right clicking the menu bar after copying a link: Screenshot from 2024-02-20 17-38-42

Right clicking a link on a webpage showing an existing Copy Without Site Tracking icon: Screenshot from 2024-02-20 17-42-19

OS

Linux

OS - Others

No response

Firefox Version

125.0a1 20240220094730

Distribution

Theme

Theme - More Info

Yaru-dark

user.js setup

user.js setup
```javascript // Your settings ```

Additional context

Application Basics Name Firefox Version 125.0a1 Build ID 20240220094730 Distribution ID mozilla-deb Update Channel nightly User Agent Mozilla/5.0 (X11; Linux x86_64; rv:125.0) Gecko/20100101 Firefox/125.0 OS Linux 6.5.0-1014-oem #15-Ubuntu SMP PREEMPT_DYNAMIC Fri Jan 19 11:03:48 UTC 2024 OS Theme Yaru-dark / Yaru Application Binary /usr/lib/firefox-nightly/firefox-bin

happy-dude commented 4 months ago

I was looking through the code to try and understand what was happening -- perhaps it is found in this file? https://github.com/black7375/Firefox-UI-Fix/blob/d91f2822b4b9f71d6fc7f7d870526fcf56719348/src/icons/context_menu/_others.scss#L142-L158

What can I do to debug further (and maybe contribute a PR)?

black7375 commented 4 months ago

Yes. If you enable userChrome.icon.menu.full as true with about:config, you can have a menu with most of the icons.

image

happy-dude commented 4 months ago

Ah, thanks for pointing out that setting! This is probably expected behavior then; I'll close this ticket :)