black7375 / Firefox-UI-Fix

🦊 I respect proton UI and aim to improve it.
Mozilla Public License 2.0
5.24k stars 183 forks source link

Address bar border with Firefox 126 #889

Closed shibotto closed 1 day ago

shibotto commented 1 month ago

Describe the bug

The active tab no longer draws on top of the address bar.

Expected behavior

The address bar border to be hidden under the active tab.

Screenshots

Firefox 125.0.3 Schermata da 2024-05-14 17-21-11

Firefox 126 Schermata da 2024-05-14 17-21-50

OS

Linux

OS - Others

No response

Firefox Version

126

Distribution

Theme

Theme - More Info

Graybird

user.js setup

I don't know where that is, sorry. I just did ./install.sh on a live environment.

Additional context

No response

black7375 commented 1 month ago

This is an issue that can occur with some themes on Linux. border-top was a problem, which I replaced with box-shadow.

shibotto commented 1 month ago

That's a smart idea, but the -0,01px box-shadow is probably the same as no shadow at all. Setting it to -1px however makes it look just like before on every GTK+ theme I tried:

Schermata da 2024-05-25 09-50-52 Schermata da 2024-05-25 09-51-02 Schermata da 2024-05-25 09-51-27 Schermata da 2024-05-25 09-52-03 Schermata da 2024-05-25 09-52-13

But of course that doesn't work as well for Firefox own themes and that 1px border-like shadow becomes really an eyesore:

Schermata da 2024-05-25 09-58-28 Schermata da 2024-05-25 09-57-17

If it's not possible to set it only when using the system theme, then probably your current solution is the best one.

black7375 commented 1 month ago

Of course, bolding is only possible in Linux system themes. Thanks to your feedback.

black7375 commented 1 day ago

A bug-fixed version has been released.