black7375 / Firefox-UI-Fix

🦊 I respect proton UI and aim to improve it.
Mozilla Public License 2.0
5.24k stars 183 forks source link

Tooltip when mouse-overing a tab has no background fill, completely transparent background #890

Closed Dwedit closed 1 day ago

Dwedit commented 1 month ago

Describe the bug

This is one is new for Firefox 126.

When you mouseover a tab, you normally get a tooltip. The tooltips are broken at the moment, instead of having an opaque background, it is missing any opacity at all, resulting in black text on a completely clear background.

Expected behavior

Should have a fill style defined for the tooltip (the same color as the toolbar and tab)

Screenshots

firefox_ui_fix_bug

OS

Windows 10

OS - Others

No response

Firefox Version

126.0

Distribution

Theme

Theme - More Info

No response

user.js setup

Tested on a fresh profile with just those files extracted.

Additional context

No response

erwin4270 commented 1 month ago

I tested this using Firefox Color.

If the toolbar color alpha (toolbar) of the theme is 0%, it's transparent. 0a

In the latest Nightly, if the popup background alpha (popup) of the theme is 0%, it's transparent

black7375 commented 1 month ago

@erwin4270 Thanks. This should make reproduction very easy, thanks for the comment. I'll try to fix the bug over the weekend.

black7375 commented 1 month ago

Fixed to base the color of the panel(popup) instead of the toolbar. (Same setting like nightly)

walking-octopus commented 1 month ago

Fix still not ported to Photon. Screenshot_20240527_171923 Reproduced on latest master.

fraencko commented 2 weeks ago

Can confirm that the issue is there on Windows 11, Firefox 126.0.1, Photon and Proton style, latest master. tooltip-bug

tml3nr commented 2 weeks ago

It's ok when i rollback v8.6.0.

Windows 10, Firefox 127.0 32bit, Lepton v8.6.0.

2024-06-16_070013

Dwedit commented 3 days ago

This issue seems to no longer happen in Firefox 127.0.2?

black7375 commented 1 day ago

Probably. I've also applied a patch to fix the issue. Try to new release.