search

blacklanternsecurity / bbot

A recursive internet scanner for hackers.
https://www.blacklanternsecurity.com/bbot/
GNU General Public License v3.0
4.1k stars 375 forks source link

Paramminer Error After Finishing Scan Manually #1337

Closed amiremami closed 2 months ago

amiremami commented 2 months ago

image

liquidsec commented 2 months ago

Did the scan conclude on its own or did you control+c it?

amiremami commented 2 months ago

I used CTRL + C

liquidsec commented 2 months ago

@TheTechromancer , isn't this a more general issue with the control+c and finish()? I'm not sure I understand how that is supposed to work currently

TheTechromancer commented 2 months ago

Ctrl+C is a hard abort and doesn't invoke or wait for .finish(). If .finish() is being invoked after a ctrl+c, it's a bug.

That being said, the bug shown here is specific to the module. You can see from the code it's not properly aborting when it hits an error:

Screenshot_20240504-122130.png

liquidsec commented 2 months ago

HttpCompareErrors will happen fairly frequently during the scan, for example of a target goes down while it is baselining it.

I think i should probably have a continue there though

liquidsec commented 2 months ago

This should be addressed in https://github.com/blacklanternsecurity/bbot/pull/1359, but I don't have a reliable way to reproduce / test it.

liquidsec commented 2 months ago

closing until/unless issue resurfaces