Closed TheTechromancer closed 1 month ago
Attention: Patch coverage is 85.71429%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 92%. Comparing base (
2901e26
) to head (16cfd28
).
Files | Patch % | Lines |
---|---|---|
bbot/scanner/manager.py | 86% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR simplifies the third status message as requested in https://github.com/blacklanternsecurity/bbot/issues/1422.
The status message normally looks like this:
And has been changed to this:
The reason was because the process of iterating through all the module queues and counting the event types was taking a very long time, roughly 10 seconds per 500K events. This could easily double or triple the length of the scan.
If this feature is requested to be brought back, we'll want to implement a custom queue with a stats counter that keeps state.