blacklanternsecurity / bbot

A recursive internet scanner for hackers.
https://www.blacklanternsecurity.com/bbot/
GNU General Public License v3.0
4k stars 366 forks source link

Tests for multiple OS families #1476

Open TheTechromancer opened 1 week ago

TheTechromancer commented 1 week ago

Addresses https://github.com/blacklanternsecurity/bbot/issues/1469.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92%. Comparing base (6f77f91) to head (efcdaff). Report is 4 commits behind head on dev.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1476 +/- ## ===================================== - Coverage 92% 92% -0% ===================================== Files 327 327 Lines 21088 21112 +24 ===================================== + Hits 19368 19373 +5 - Misses 1720 1739 +19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

TheTechromancer commented 1 week ago

@domwhewell-sage we've run into a potential issue with these tests. In order to test BBOT on multiple OS families, we need to run the tests inside a docker container. This will cause the dastardly tests to fail, since we can't do docker-in-docker.

🤔🤔

domwhewell-sage commented 1 week ago

Do you think it would be possible to add this to the dastardly test

@pytest.mark.skipif(not subprocess.run(['docker', '--version'], capture_output=True).returncode == 0,
                    reason="Docker is not installed")
TheTechromancer commented 1 week ago

Hmm I guess we could exclude it from the os family tests, but modules like dastardly with big dependencies are the reason we need those tests to begin with.

I'll see about excluding it for now, and maybe we can figure out a better solution further down the road.