Better tests for portscan module - Githubissues

blacklanternsecurity / bbot

A recursive internet scanner for hackers.

https://www.blacklanternsecurity.com/bbot/

GNU General Public License v3.0

4k stars 366 forks source link

Better tests for portscan module #1516

Closed TheTechromancer closed 8 hours ago

TheTechromancer commented 3 days ago

In the portscan module, we should make sure that:

[x] Targets are sorted by length so that bigger IP_RANGE events are added first
[x] Individual IP_ADDRESS events are not being scanned if their parent IP_RANGE has been scanned already
[x] Hostnames sharing the same IP should still raise OPEN_TCP_PORT events, even if the IP has been scanned already
[x] Discovery chains are correct regardless of whether the source event is an IP_ADDRESS, IP_RANGE, or DNS_NAME
[x] Test ping mode

Thanks to @amiremami for discovering some bugs in the new portscan module.

TheTechromancer commented 8 hours ago

Added in https://github.com/blacklanternsecurity/bbot/pull/1517.