blockmason / lndr-mobile

LNDR mobile app in React Native
http://lndr.io/
15 stars 10 forks source link

Fixed tx cost display for ETH and BCPT transfer #326

Closed willbach closed 6 years ago

willbach commented 6 years ago
  1. Problem: The ETH tx cost is not displaying correctly in the correct currency on the Transfer ETH and Transfer BCPT dialogs. https://blockmason.atlassian.net/secure/RapidBoard.jspa?rapidView=9&projectKey=ENG&selectedIssue=ENG-155
  2. Solution: Add the ETH tx cost to the BCPT dialog and fix the display on the Transfer ETH page
  3. No concerns
  4. No blockers
arutun commented 6 years ago

There are still a couple of decimal numbers on this screen that are not properly displaying the locale's decimal character, and that appears to be the case on several other screens.

Transfer Eth

Transfer BCPT

My Account

Home

Settlement

arutun commented 6 years ago

When Settling Up with Eth - we use a TextInput - in this case there is a strange 20 pixel tall white bar on the bottom of the screen.

screen shot 2018-08-03 at 11 24 18 am

arutun commented 6 years ago

Getting close!

I did find one thing on Settle Up, we now set the settlement amount on mount 👍, but we don't see the Eth amount unless we edit the text field.

arutun commented 6 years ago

Also, the 20 pixel white bar still shows up if we edit the text field.