Closed mattfelsen closed 6 years ago
benjaminbojko
commented
6 years ago This looks great. Can I ask for one nitpicky thing though: Can we rename it to NO_TOUCH? Then we can extend that later on to NO_... for other features a little more legibly. Was also wondering if we should prefix it with something specific for this block (VIEWS_ or BC_), but this seems general enough to keep as is.
mattfelsen
commented
6 years ago Haha, not nitpicky and I had the same thoughts on both :) I actually used NO_TOUCH initially but saw there's an existing def for NOMINMAX, I think from Cinder, so went with that style. Also thought of BCV_ as a prefix, but 🤷♂️ LMK what you want, happy to change
benjaminbojko
commented
6 years ago Ha, yeah I took a peek too at Cinder and it seems like there's a mix of UNDER_SCORE and just EVERYTHINGTOGETHER. I'd say let's go with NO_TOUCH for legibility and that'll make it consistent with the very few defines we currently have in the block.
mattfelsen
commented
6 years ago benjaminbojko
commented
6 years ago Looks good, thanks @mattfelsen !
I had been thinking about this previously in order to avoid needing the Osc & TUIO blocks, but after needing to do rebuilds in VS frequently lately this seemed like a worthwhile effort.
To create/modify a Views project to remove touch support:
Osc&TUIOblocks from the VS projectbluecadet/touchfolder from theViewsblockTouchView.h/.cppcan remain in the project - no need to remove thatNOTOUCHpreprocessor def to your project (make sure to do bothDebug&Release!)I suppose everything in the
bluecadet/touchfolder could also be wrapped in an#ifndefso that files don't have to be removed, but it seemed excessive.And no, of course I didn't measure how much less time it takes.