bluecadet / Cinder-BluecadetViews

Scene graph Cinder block with touch management and various tools for UI dev
MIT License
11 stars 3 forks source link

Question: Merge Views + Touch Blocks? #51

Closed benjaminbojko closed 8 years ago

benjaminbojko commented 8 years ago

It may be controversial to pose this question now that we have running projects using both blocks, but I'm proposing to merge the Views and Touch blocks. The main reason is that they are just so tightly coupled (not inherently bad) that making changes in one block most often results in changes in the other.

Additionally, the Touch block really doesn't serve a purpose w/o the Views block. I've found myself in a few situations where I fixed something in Views and then had to do two separate pull requests in both repos or just simply forgot to update and push changes from one or the other block.

What I would like to do:

  1. Migrate all Cinder-BluecadetTouch source files and samples to CinderBluecadetViews
  2. Migrate all classes and types from bluecadet::touch to bluecadet::views (debatable, but given the fact that we won't have a Touch block I thought we shouldn't pack files into a "hidden" namespace)
  3. Delete/archive the Cinder-BluecadetTouch repository

That's really it. Please let me know what you think.

Swiley commented 8 years ago

Yea I know why we did it to start with, but after using it I think this makes sense and would help. I can take a pass at integrating them into the MoAR projects, we'll just have to see what stage we're at when this revision is ready - I think we're going to be on hold for a little followed by a mad dash - so we'll fit it if we can!

What do you think about folder structure? One idea, BluecadetViews >src > touch BluecadetViews > src > views (could potentially pull out BluecadetViews > src > layout since screenlayout isn't really a view)

or should they all be together? maybe totally different? I think sharing a namespace is ok.

benjaminbojko commented 8 years ago

Great! Good question regarding folder structure/namespaces. I'm a little torn: We have a few things in there that aren't technically views. At this point I'm almost wondering if we should also merge in the SettingsManager. Then we could have something like:

I think the text block definitely still warrants its own repo since it's completely independent. I'm not sure if the ImageManager is independent enough to live in a utils repo, but once we add things like TaskQueue, ThreadManager and AnalyticsManager it still makes sense in my mind.

benjaminbojko commented 8 years ago

Completed in #60