search

bluelabsio / s3-stream

Akka Streaming Client for S3 and Supporting Libraries
Other
16 stars 6 forks source link

Add support to GET the contents of S3 buckets #6

Closed jypma closed 8 years ago

jypma commented 8 years ago

@joearasin This implements https://github.com/bluelabsio/s3-stream/issues/5 .

How would we go about writing a "unit" test for this? Does AWS provide some kind of testing setup that doesn't require us to put keys up on github?

joearasin commented 8 years ago

I totally punted on the integration test in the upload-side. I unit-tested the innards, but it definitely makes sense to put something together.

I can toss an encrypted credential in the travis.yml that we could use for testing -- Any idea what other libraries are doing for this?

joearasin commented 8 years ago

I like the refactor, as well

jypma commented 8 years ago

Nope, I don't know what other libs are using unfortunately.

Adding encrypted variables to travis is a really good idea, but wouldn't help in our case: pull requests from forks don't get to use encrypted variables, since a fork could (intentionally or inadvertedly) expose the secrets. I guess there's some sense to that.

What should we do? Write a manual test then?