search

bluelabsio / s3-stream

Akka Streaming Client for S3 and Supporting Libraries
Other
16 stars 6 forks source link

AWS Credentials & multipart checksum #8

Closed jasonmartens closed 8 years ago

jasonmartens commented 8 years ago

Add AWS Credential lookup, similar to the AWS SDK, and a checksum validator for the multipart upload.

joearasin commented 8 years ago

Looking at this, I think the right abstraction to work with in the context of credentials that change over time is to have a Source[Credential] (which might well be Source.repeat(constantCredential). rather than passing in a constant credential.

jasonmartens commented 8 years ago

I think that is probably a nicer solution. Not sure I will have time to work on it, but we shall see.

jasonmartens commented 8 years ago

Also, just to clarify the credentials are not constant. There is a self-refreshing version for an EC2 instance.

jasonmartens commented 8 years ago

This PR is superceded by #11