Remove unused `resource_roundtrip()` from test suite?

bluesky / databroker

Unified API pulling data from multiple sources

https://blueskyproject.io/databroker

BSD 3-Clause "New" or "Revised" License

33 stars 45 forks source link

Remove unused `resource_roundtrip()` from test suite? #805

Open padraic-shafer opened 5 months ago

padraic-shafer commented 5 months ago

This is not a test, and the function is not called anywhere. This dead code should probably be removed. Or could someone clarify what functionality is intended to be tested here?

https://github.com/bluesky/databroker/blob/23071d5cca95955e0dcd65e258afd13463fe2f99/databroker/tests/test_broker.py#L1124-L1138

tacaswell commented 5 months ago

It came in via a915611cbde03ddc7120cf7d423ea2ad616af40c so I think it should have been named test_resource_roundtrip 🤦🏻 .

tacaswell commented 5 months ago

and what I think this is testing is that the documents that come out of databroker can go back into databroker.