search

bmcfee / pumpp

practically universal music pre-processor
ISC License
60 stars 11 forks source link

Added name defaults #117

Closed beasteers closed 2 years ago

beasteers commented 5 years ago

Fixes #114

beasteers commented 5 years ago

Hmm I mean like you said, most of them are already doing that. Yeah I guess the obvious name for those two could be the namespace? But there isn't really a way to avoid changing the API. The closest I think we could get without changing parameter order could be this:

def __init__(self, name, namespace=None):
    namespace = namespace or name

But really that's backwards. This would make more sense:

def __init__(self, namespace, *, name=None):
    name = name or namespace

But I think it could be okay leaving them as required for now

bmcfee commented 5 years ago

But I think it could be okay leaving them as required for now

I agree. Let's call this one done then? (Thanks!)

bmcfee commented 5 years ago

I'm gonna hold off on merging this for a minute to see if it still makes sense to do a 0.5.1 release at all, or just push ahead to 0.6.0.

codecov-commenter commented 2 years ago

Welcome to Codecov :tada:

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered :open_umbrella: