bongochong / CombinedPrivacyBlockLists

Ad-blocking hosts files, IP block lists, PAC filters, ABP / uBO / ADG subscriptions, and a whole lot more. All merged from multiple reputable sources, combined with my own research. Also, script-based utilities to help you create such things yourself. Updated at least once every two weeks, often more frequently.
Other
224 stars 25 forks source link

[RESOLVED, though more exceptions can be added in the future] seems filters ||graph.facebook.com^ break the apps/some apps #11

Closed What-Zit-Tooya closed 3 years ago

What-Zit-Tooya commented 3 years ago

Hello there, Im using your filter list in AdGuard for Android, but some apps broken (like games) and Facebook app can't refresh the timeline. In the AdGuard Log's, there is ||graph.facebook.com^ that the culprit (may be) . Im using this link https://raw.githubusercontent.com/bongochong/CombinedPrivacyBlockLists/master/cpbl-abp-list.txt Does possible to remove it? OS: Android 10 (EMUI 11)

bongochong commented 3 years ago

I can add a rule which allows graph.facebook.com on certain sites (like facebook itself). If you would like this domain to be whitelisted on other sites please let me know. This domain is involved in a lot of cross-site tracking, so I can't remove it from my lists completely, but have no problem adding exception rules in my ABP/uBO filter lists to allow for better functionality on specific sites.

I also highly recommend using free and open source clients for facebook (if you must use facebook at all). SlimSocial and Frost are nice (and the timeline will be able to refresh in those applications with the domain in question blocked).

What-Zit-Tooya commented 3 years ago

I can add a rule which allows graph.facebook.com on certain sites (like facebook itself). If you would like this domain to be whitelisted on other sites please let me know. This domain is involved in a lot of cross-site tracking, so I can't remove it from my lists completely, but have no problem adding exception rules in my ABP/uBO filter lists to allow for better functionality on specific sites.

I also highly recommend using free and open source clients for facebook (if you must use facebook at all). SlimSocial and Frost are nice (and the timeline will be able to refresh in those applications with the domain in question blocked).

If you can't remove it completely, i'm sure with you to add whitelist to that domain. And yes, that domain also used to sent ads on some apps/games. I'll try to using Frost, seems it trustworthy Facebook app replacement. :)

bongochong commented 3 years ago

I should have the necessary exception rules in place tomorrow, but I'll leave this issue open for a while so I remember to test it out on a few different sites which necessitate facebook integration for functionality. Will leave another comment with a link to upcoming relevant commits.

bongochong commented 3 years ago

Alright!

As you can see from this commit, my Adblock Plus / uBlock Origin filter lists will from now on exclude graph.facebook.com from being blocked on certain domains. I made the same changes for Instagram as well. I'll close this issue for now, but if you want other sites added to the relevant exception lists, just add a comment (no need to re-open the issue, as I'll check back from time to time) and I'll work on it.

Currently, the two modified filters look like this: ||graph.facebook.com^$domain=~facebook.com|~fbcdn.com|~apps.facebook.com|~instagram.com|~linkedin.com

||graph.instagram.com^$domain=~facebook.com|~fbcdn.com|~apps.facebook.com|~instagram.com|~linkedin.com

Thanks for contributing to the improvement of these lists!

Edit: I should also add that standard whitelist rules (for example, @@||graph.facebook.com) are fine temporary workarounds should you ever run into issues like this again, if I can't remedy it as quickly as I usually do.

What-Zit-Tooya commented 3 years ago

Thank you, seems two modified filters are works on domain / web browser (like Chrome) to have access into Facebook. I updated your filterlist on AdGuard Android, Facebook app still can't refresh timeline. But when i add @@||graph.facebook.com this filter works (globally works).

So, if i want to whitelist ads on some apps, like Facebook i add @@||graph.facebook.com^$app=com.facebook.katana on AdGuard, this will unblock ads on Facebook, but still block ads on another apps like Instagram. Because that domain usefull on Facebook to reach their server but on another apps like games it will deliver ads.

bongochong commented 3 years ago

Thank you, seems two modified filters are works on domain / web browser (like Chrome) to have access into Facebook. I updated your filterlist on AdGuard Android, Facebook app still can't refresh timeline. But when i add @@||graph.facebook.com this filter works (globally works).

So, if i want to whitelist ads on some apps, like Facebook i add @@||graph.facebook.com^$app=com.facebook.katana on AdGuard, this will unblock ads on Facebook, but still block ads on another apps like Instagram. Because that domain usefull on Facebook to reach their server but on another apps like games it will deliver ads.

Ah, well, filter lists themselves can't whitelist by application (unless AdGuard has implemented this as a feature, in which case please link me to the documentation, because that would be amazing). I imagine the AdGuard program itself must have a feature which allows disabling ad-blocking per app too.

What-Zit-Tooya commented 3 years ago

Here the list of explanation about AdGuard own filters : https://kb.adguard.com/en/general/how-to-create-your-own-ad-filters#app But, rest of it, AdGuard highly accept ad-filters from AdBlock Plus like your filters.

bongochong commented 3 years ago

Here the list of explanation about AdGuard own filters : https://kb.adguard.com/en/general/how-to-create-your-own-ad-filters#example-unblocking-an-address But, rest of it, AdGuard highly accept ad-filters from AdBlock Plus like your filters.

I'm familiar with the rest, but was absolutely not familiar with this section: https://kb.adguard.com/en/general/how-to-create-your-own-ad-filters#app-modifier

Apparently, list maintainers like myself can whitelist by application, as you suggested. That's really neat. I'll definitely add an exception for com.facebook.katana, and please let me know if there are other application identifiers you suggest as well.

bongochong commented 3 years ago

Already added some basic ones. See the commit here for reference: https://github.com/bongochong/CombinedPrivacyBlockLists/commit/9f6af4131e386bbbab60c419975ec9fd244506a1

I can add more as necessary. Thanks for pointing out this AdGuard feature to me. I'm more used to utilizing the hosts file on rooted Android devices, and Blokada on non-rooted devices. AdGuard's application seems great.

What-Zit-Tooya commented 3 years ago

Here the list of explanation about AdGuard own filters : https://kb.adguard.com/en/general/how-to-create-your-own-ad-filters#example-unblocking-an-address But, rest of it, AdGuard highly accept ad-filters from AdBlock Plus like your filters.

I'm familiar with the rest, but was absolutely not familiar with this section: https://kb.adguard.com/en/general/how-to-create-your-own-ad-filters#app-modifier

Apparently, list maintainers like myself can whitelist by application, as you suggested. That's really neat. I'll definitely add an exception for com.facebook.katana, and please let me know if there are other application identifiers you suggest as well.

Seems that model ads-exeption is only for AdGuard app.

I have some apps that i used daily like games and another aps.s Usually Facebook used to save progress or login using Facebook account.

My lists: com.facebook.katana com.facebook.orca com.instagram.android com.mobile.legends com.minigames.sweetcrossing com.moonton.mobilehero com.supercell.clashofclans com.playrix.fishdomdd.gplay com.tencent.ig com.ngame.allstar.eu com.garena.game.kgid com.netease.g78na.gb com.stackwares.android.storysaver.facebook

These lists just mine, need volunteers (may be) to add another android package name because different person different apps/games.

bongochong commented 3 years ago

Those are all added now too!

https://github.com/bongochong/CombinedPrivacyBlockLists/commit/d9d64b94dc54b20e270ed815aea6d68241806dd7

I had no idea that AdGuard's Android app could do this until now. Really nifty. Going to try and keep this capability in mind from now on.