boostorg / mysql

MySQL C++ client based on Boost.Asio
https://www.boost.org/doc/libs/master/libs/mysql
Boost Software License 1.0
253 stars 32 forks source link

Limits: the write buffer may surpass max_buffer_size #297

Closed anarthal closed 2 months ago

anarthal commented 3 months ago

In #278 we implemented a check to make write operations fail if they attempt to write packets bigger than max_buffer_size. However, this is checked after the buffer is resized. This yields the correct user-facing behavior, but doesn't actually constrain memory. The correct implementation is a little bit more involved, and should go together with #279.