search

boostorg / mysql

MySQL C++ client based on Boost.Asio
https://www.boost.org/doc/libs/master/libs/mysql
Boost Software License 1.0
252 stars 32 forks source link

Add support for modular build structure. #320

Closed grafikrobot closed 3 weeks ago

grafikrobot commented 1 month ago

This is part of the effort to make the Boost libraries "modular" for build and consumption. See https://lists.boost.org/Archives/boost/2024/01/255704.php and https://github.com/grafikrobot/boost-b2-modular/blob/b2-modular/README.adoc for more information.

This PR depends on the following other PRs being merged to both develop and master branches of the respective repos:

This PR will be changed to ready for review, i.e. not draft, when the above are merged. Do not merge this one until that time.

anarthal commented 1 month ago

Looks like the docs build broke: https://drone.cpp.al/boostorg/mysql/784/39/2

grafikrobot commented 1 month ago

Looks like the docs build broke: https://drone.cpp.al/boostorg/mysql/784/39/2

Indeed. I'll be making some changes very soon (which Peter also brought up as a problem) to deal with that.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.03%. Comparing base (00bc812) to head (a7604c4).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/boostorg/mysql/pull/320/graphs/tree.svg?width=650&height=150&src=pr&token=ajbbjm3OiO&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg)](https://app.codecov.io/gh/boostorg/mysql/pull/320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg) ```diff @@ Coverage Diff @@ ## develop #320 +/- ## ======================================== Coverage 99.03% 99.03% ======================================== Files 144 144 Lines 7122 7122 ======================================== Hits 7053 7053 Misses 69 69 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/boostorg/mysql/pull/320?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/boostorg/mysql/pull/320?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg). Last update [00bc812...a7604c4](https://app.codecov.io/gh/boostorg/mysql/pull/320?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg).
grafikrobot commented 3 weeks ago

Please review and merge this PR at your earliest convenience.