search

boppreh / steamgrid

Downloads images to fill your Steam grid view
MIT License
675 stars 42 forks source link

Non-steam game gets skipped (not processed at all) #110

Closed DinoMC closed 2 years ago

DinoMC commented 2 years ago

I have 5 non-steam apps installed right now but when I run steamgrid it goes "Processing Firefox (1/4)", then goes through 4 and ends successfully, as if the 5th one didn't exist.

The missing one is the latest non steam game I added, manually, the exact same way as another one that does get processed. Any idea why this one gets skipped?

The one thing different for the skipped one is that it's installed on an SD card rather than the internal storage, could this be the issue?

PS. This is on Steamdeck, archlinux.

Edit : It appears to be linked to it being on the SD card, indeed. I tried copying the .exe to the /home folder and adding that as a non-steam game, and it works in that case.

Any idea how to have it work for games on the SD card too?

SD card folder is /run/media/mmcblk0p1 , game is in a sub folder

Edit 2 : Added more games on SD card and they don't have this issue. It's just the one game that always get skipped. I guess it's no big deal, I'm just gonna set pictures manually for that game. Leaving this up in case you want more info.

NightHammer1000 commented 2 years ago

Sometimes it skips new Shortcuts for me too. The solution to this is was to Rename the Shortcut in Steam, Run steamgrid again and change the name back.

aph3rson commented 2 years ago

I'm also hitting the same issue. I've tried renaming the shortcut in question, but steamgrid refuses to pick up the shortcut. It's specifically showing a smaller number of shortcuts than I have in that file.

Could we perhaps get some more useful output in addNonSteamGames(), specifically inside the for loop for parsing games?

e: In case it helps, here's my shortcuts file. Discord is the one which refuses to be picked up. shortcuts.vdf.zip

NightHammer1000 commented 2 years ago

Yep. Run into that now too. Added GOG Galaxy to my shortcuts and steamgrid just seems to ignore it for some Reason too. Not even Renaming works on that one.

DinoMC commented 2 years ago

In my case, renaming didn't work either. But after adding the same game again, with the same executable, the second "copy" did get picked up by Steamgrid.

NightHammer1000 commented 2 years ago

By the looks of all the other open Issues, the Dev is no longer interrested in supporting this. I will have a look at this when I have a bit of free time.

NightHammer1000 commented 2 years ago

I recommend using BoilR https://github.com/PhilipK/BoilR

Running it with all the Import Extensions disabled just pulls Images for Non-Steam Shortcuts.

kmicki commented 2 years ago

The shortcuts are skipped because for some reason unknown to me (I don't know go) the regex that parses the shortcut.vdf file doesn't work correctly. For me it produces 128 matches:

image

But when I use the exact same regex pattern with Notepad++, it produces correct 146 matches:

image

So it looks like it's something wrong with regex implementation in go.

kmicki commented 2 years ago

I just found out that it is because regexp in go matches Unicode text and when you try to match (.{4}) and, in my file, in this place there are bytes: DB A1 82 9B then DB A1 is interpreted as a single Unicode character. To make it work properly regex matching would have to be forced not to use Unicode.