boppreh / steamgrid

Downloads images to fill your Steam grid view
MIT License
671 stars 42 forks source link

onlymissingartwork not really skipping existing files #137

Open grgohr opened 1 year ago

grgohr commented 1 year ago

the -onlymissingartwork flag seems to still manage/modify existing files (log shows "xxx found from backup" + date files are modified "for nothing" in the /grid and /grid/originals folders although previously there) instead of actually skipping existing files and looking for a few missing files only.

i am running with -nonsteamonly -onlymissingartwork -steamgriddb id when 99% of non steam files are ok, but the program still spends most of its time looking for and modifying existing files in "backup", often leading to an out of memory error (another open issue) and not looking for the missing files which was the initial purpose image

Lucki commented 1 year ago

Append --onlymissingartwork to only download artworks missing on the official servers.

This option only makes sure to fetch artworks where steam won't provide any and not override otherwise. This makes sure older games where no vertical artwork exists (and steam blurs the horizontal artwork awkwardly in) will get proper artwork and official artwork won't be overridden at the same time.

The other option --nonsteamonly actually renders --onlymissingartwork useless because there aren't any steam games to begin with while the round trips are still in place. You probably want --skipsteam.

grgohr commented 1 year ago

thank you for the explanations, I better understand the options now.

Still is there any option not to re-write files when already present in the /grid folder ? I feel that files are modified/overwritten even if previously there/the same ?

I guess this is related to the overlays which are probaly recalculated each time (makes senses) but I removed its folder on purpose (maye a --skipoverlay option might be an answer ?)