boppreh / steamgrid

Downloads images to fill your Steam grid view
MIT License
665 stars 42 forks source link

50 images were found but had errors... #36

Closed gregbrunk closed 7 years ago

gregbrunk commented 7 years ago

First off - thank you - awesome program. Overlays make a huge different in my grid view. Well done.

What does the Unknown Format error mean? I would assume all the files pulled in from your DB would be in a compatible format. It found images for every single one of my side-loaded games, but couldn't apply to any of them.

50 images were found but had errors and could not be overlaid:

gregbrunk commented 7 years ago

Also, another issue: Any manually added custom images (for side-loaded games) that I had added before using SteamGrid for the first time all received the correct overlay when SteamGrid was run. However, any custom images that I put in now, since running for the first time, are being ignored and overlays are not being applied when I re-run SteamGrid. Any ideas? I can make this a separate issue if you would like.

boppreh commented 7 years ago

What does the Unknown Format error mean?

It downloaded the file and expected an image, but the file was something else. Currently jpeg and png are supported. I'll have to take a look what could be happening.

I would assume all the files pulled in from your DB would be in a compatible format.

I don't have a database. The images are pulled either from the official Steam games, or by doing a google image search for the specific size.

Also, another issue: Any manually added custom images (for side-loaded games) that I had added before using SteamGrid for the first time all received the correct overlay when SteamGrid was run. However, any custom images that I put in now, since running for the first time, are being ignored and overlays are not being applied when I re-run SteamGrid. Any ideas? I can make this a separate issue if you would like.

When it downloads an image, it also makes a backup copy. This is necessary in case you want to change the overlay, for example. It is probably pulling these backups instead of your new custom images. This is an issue that has no clear answer at the moment, but as a workaround you can go to the folder where the images are and manually erase the backup files for the games you want to customize the images.

I'll take a look at the other issues and give you a response later.

gregbrunk commented 7 years ago

It downloaded the file and expected an image, but the file was something else. Currently jpeg and png are supported. I'll have to take a look what could be happening.

Interesting. It seemed like it was finding files, but wasn't actually downloading them because there was an error, because when I ran it in successive tries, it would say 50 images found but 0 downloaded. But I think thats because it did download them the first time, and now it is just checking them and they are all corrupt.

I don't have a database. The images are pulled either from the official Steam games, or by doing a google image search for the specific size.

Ah, my bad. I just assumed you were pulling from http://www.steamgriddb.com/. Not sure why I assumed your products were related.

When it downloads an image, it also makes a backup copy. This is necessary in case you want to change the overlay, for example. It is probably pulling these backups instead of your new custom images. This is an issue that has no clear answer at the moment, but as a workaround you can go to the folder where the images are and manually erase the backup files for the games you want to customize the images.

So, could I solve this by going to Steam/userdata/ID/config/grid and deleting the files for my side-loaded games, manually adding custom images, then running the SteamGrid again? Or are the backups stored elsewhere?

boppreh commented 7 years ago

So, could I solve this by going to Steam/userdata/ID/config/grid and deleting the files for my side-loaded games, manually adding custom images, then running the SteamGrid again? Or are the backups stored elsewhere?

Precisely. The code is at https://github.com/boppreh/steamgrid/blob/master/backup.go . The name of the file is the Steam ID of the game, and the backup has the same name but an "(original)" appended. If you delete both the image and its backup, then you can set a custom image again.

I know this should be simpler/clearer, but it's not clear to me how, other than just mentioning in the README. Any suggestions are welcome.

gregbrunk commented 7 years ago

Lovely! Thanks man. If you do have any ideas why it downloaded images for every one of my non-steam games, but was never able to use any of them, that would be great. I did look in the folder and every one of those files is a corrupted .jpg with a very long ID and wont open in windows, so could be related to https://github.com/boppreh/steamgrid/issues/32. I have attached one of the files if it helps. 9948973960882290688 original

boppreh commented 7 years ago

Oh, I see. Try renaming the "corrupted" image to "anything.html" and opening in your browser. This seems to be a duplicate of issue #32 , which was fixed in the master branch but hasn't been released yet.

I'll try to do a release now.

gregbrunk commented 7 years ago

When I do that, it just loads Steam's Store page. Which probably indicates that #32 is this issue. A release would be awesome! Ill close this now. Thanks for the fast responses and awesome app. Appreciate it.