boppreh / steamgrid

Downloads images to fill your Steam grid view
MIT License
672 stars 42 forks source link

Some images in Steam Grid/games are not being recognized #46

Open VisionaryLion opened 6 years ago

VisionaryLion commented 6 years ago

I was hoping to make it faster by putting all my custom images in the games folder and then running once and forgetting. But I'm noticing that some games just don't want to recognize the game title. For example Star Wars The Knights of the Old Republic or ABZU. I had to put their ids instead but I'd prefer to keep all my images to the game titles. Maybe I'm entering the game titles incorrectly?

boppreh commented 6 years ago

This may be a problem with special characters. I see ABZU is spelled "ABZÛ" in some marketing material, and SWKOTOR is a long title.

The function that loads games by name is https://github.com/boppreh/steamgrid/blob/master/backup.go#L60 . I'm doing some tests now.

Also, are you by any chance on Linux? Maybe capitalization is the problem on SWKOTOR, since Linux has case-sensitive file names. Try using the exact same casing as the store title.

VisionaryLion commented 6 years ago

I'm not on Linux no. I'm on Windows 10. But it seems to be case sensitive. One game (I forget which now) seemed to work after I made the title's first letter a capital. I also thought it was maybe the : that comes in a lot of titles. Since you can't put that symbol in when saving an image. But Amnesia The Dark Descent worked where as Amnesia A Machine For Pigs did not. Maybe because I capitalized For?

VisionaryLion commented 6 years ago

Is there a way to reset all my images back to default to test this?

boppreh commented 6 years ago

You can reset an image manually by deleting the file on C:\Program Files (x86)\Steam\userdata\{YOUR_ID}\config\grid and in the originals folder under the same path.

The code that looks for game name works like this:

Please double check the capitalization with the name printed on the game list when running tool. If that's the only problem, I can make some changes to accept different capitalizations.

VisionaryLion commented 6 years ago

Ok I'll do that and get back to you. It'll take me some time. Thanks. I'm happily surprised you got back to me some quickly.

boppreh commented 6 years ago

No worries, I'm going to sleep now.

VisionaryLion commented 6 years ago

Ok so I took a look at how the name of the game is in Steam and made sure my file names match it. Then went and looked at what the tool says for the images that still don't work:

ABZÛ I put ABZU for the image name The tool says it's ABZ\u00db Like you said, probably due to the special character.

STAR WARS: Knights of the Old Republic I put STAR WARS Knights of the Old Republic for the image name The tool says STAR WARS\u2122: Knights of the Old Republic\u2122 I think this is because of the : and the trademark symbols at the end of star wars and old republic.

STAR WARS Knights of the Old Republic II: The Sith Lords I put STAR WARS Knights of the Old Republic II The Sith Lords for the image name The tool says STAR WARS\u2122 Knights of the Old Republic\u2122 II: The Sith Lords\u2122 Again there are the trademark symbols where the tool put the u2122

Batman: Arkham Knight I put Batman Arkham Knight for the image name The tool says Batman\u2122: Arkham Knight Batman also has a trademark symbol after it.

Batman: Arkham Origins I put Batman Arkham Origins for the image name I can't find what the tools says since my game list is too long but I'm guessing it has to do with the tm symbol again.

Note this was only for a dozen or so of my games. Caps also seem to be important. If a single letter has the wrong caps the tool won't read your custom image. Once we settle this stuff I'll try the rest of my 300+ library.

VisionaryLion commented 6 years ago

Apparently adding the u2122 to the image file names work except that I also found another bug. For some reason the tool thinks these two games are the same image. I ended up with having the image for KOTOR 2 on both games. STAR WARSu2122 Knights of the Old Republicu2122 STAR WARSu2122 Knights of the Old Republicu2122 II The Sith Lordsu2122

Interestingly enough GTA IV and V did the same thing which is strange since they have no special characters. The tool gave me the GTA IV art for both IV and V.

boppreh commented 6 years ago

Ah, that makes sense. I thought the \W regular expression would also remove trademark symbols, but apparently I was wrong. I'll be more specific and remove anything that is not a letter, a number or a space.

Speaking of which, since spaces match the \W expression, they are being aggressively ignored and accepting any other string. This is why your KOTOR1 matched KOTOR2 (it's a substring), and why GTA V matched GTA IV (the * that replaced the space matched the I).

Totally my fault, sorry. I'm working on the solution.

VisionaryLion commented 6 years ago

Ah ok I think I get what ya mean. Seems like a simple enough mistake to make. And will you also be adjusting the capitalization requirement?

And no worries, no need to apologize. You've got an amazing program here. I couldn't do half of what you've already done. I really appreciate your commitment to it. I saw the last commit was from 2017 so I didn't even think I'd get a response. Kudos for being awesome :). And looking forward to the fixes.

VisionaryLion commented 6 years ago

After I'll make sure to send you a pic of my beautiful steam library you've helped me create and spread the word on FB

VisionaryLion commented 6 years ago

Another thing I've noticed is if the images are HD then there's some strange scaling issue. I thought I saw someone post about that already though?

VisionaryLion commented 6 years ago

Hi :). Any news?

JonathanPitre commented 1 year ago

I have the same issues with title with ":" or "!" in the name.

image