[Suggestions] Add other search engines alternatives, instead of using Google

boppreh / steamgrid

Downloads images to fill your Steam grid view

MIT License

671 stars 42 forks source link

[Suggestions] Add other search engines alternatives, instead of using Google #72

Open PoorPocketsMcNewHold opened 4 years ago

PoorPocketsMcNewHold commented 4 years ago

Surely a low priority suggestion for some, but an absolute necessity for others, to not make this functionality not totally useless. I suggest the possibility to add other choices of possible search engines to be used, either if the first one doesn’t work/doesn’t get any results, or if the user chooses to (By implementing an argument, similar to -search qwant or -search duckduckgo for example).

Lucki commented 4 years ago

What's wrong with SteamGridDB?

Anyway, you'll need a function which returns an image URL similar to the already existing one but for your search engine…

Download the page or make an API request
Scan and filter the page or API result
Extract the image URL that suits best

https://github.com/boppreh/steamgrid/blob/84dcf7a5bad834c0318554117bb1b1e4a5d78ddb/download.go#L28-L66

…and include it in the function which tries one source after another:

https://github.com/boppreh/steamgrid/blob/84dcf7a5bad834c0318554117bb1b1e4a5d78ddb/download.go#L317-L364

PoorPocketsMcNewHold commented 4 years ago

There's indeed nothing wrong with SteamGridDB. It’s just for the ¨last way¨ option that steamgrid seems to use, by querying for art on Google. I’ll take a look one trying to implement it, even if I can’t promise anything. Thanks for explaining it!